Misleading error message when specifying a wrong update policy

Bug #1358512 reported by Thomas Herve
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Peter Razumovsky
Kilo
Fix Released
Undecided
Steve Baker

Bug Description

This is really due to our poor testing, but I realized that if you specify like in our tests "UpdatePolicy": "foo": {}, you get a validatio error "Unknown Property: foo". This is because update_policy is a Properties object, but the message should be customized to be understandable.

Zane Bitter (zaneb)
Changed in heat:
status: New → Triaged
Changed in heat:
assignee: nobody → Razumovsky Peter (prazumovsky)
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/127150
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3ad4614276ff460cd8d034216c078577f148160e
Submitter: Jenkins
Branch: master

commit 3ad4614276ff460cd8d034216c078577f148160e
Author: Peter Razumovsky <email address hidden>
Date: Wed Oct 8 19:19:13 2014 +0400

    Improve StackValidationFailed response in properties

    In some cases, there is no information about resource and
    section, where Property error raised. This patch improves
    StackValidationFailed msg, so this msg look like "Property
    error : resource_name.section_name.key_name: error_msg", where
    section_name is section, where Property error raised, e.g.
    'update_policy'.

    Change-Id: Iab2a6acdec254b39983de420ab03f994cff48d89
    Closes-bug: #1358512

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195850

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/195850
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c0d1b9168d7c11a57877d0e9b37eb106d75e2d0a
Submitter: Jenkins
Branch: stable/kilo

commit c0d1b9168d7c11a57877d0e9b37eb106d75e2d0a
Author: Peter Razumovsky <email address hidden>
Date: Wed Oct 8 19:19:13 2014 +0400

    Improve StackValidationFailed response in properties

    In some cases, there is no information about resource and
    section, where Property error raised. This patch improves
    StackValidationFailed msg, so this msg look like "Property
    error : resource_name.section_name.key_name: error_msg", where
    section_name is section, where Property error raised, e.g.
    'update_policy'.

    Cherry-picked from 3ad4614276ff460cd8d034216c078577f148160e
    Change-Id: Iab2a6acdec254b39983de420ab03f994cff48d89
    Closes-bug: #1358512

Changed in heat:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.