heat/api/openstack/v1/actions action api reports wrong response code

[Kanagaraj Manickam]

action () method validates for the self.ACTIONS in first place and throws BAD REQUEST response.

But at the end of this method, 500 response code is thrown which is an dead code and will never get executed. so remove it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122603

[Steven Hardy (shardy)]

FWIW I put that else there deliberately, so we return an appropriate error response if anyone ever updates ACTIONS without adding a new conditional. I suppose it's dead code, but on balance I see no disadvantage to leaving it there.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kanagaraj Manickam (<email address hidden>) on branch: master
Review: https://review.openstack.org/122603
Reason: Abandoning this change set as reviewers felt that, its does no add much value at this moment !.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308870

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rico Lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/308870
Reason: Hi, this patch stays untouched for few months, would like to abandon for now. Feel free to restore it if you still working on this. Thank you!