heat/api/openstack/v1/actions action api reports wrong response code

Bug #1352476 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
In Progress
Low
Pankaj Mishra

Bug Description

action () method validates for the self.ACTIONS in first place and throws BAD REQUEST response.

But at the end of this method, 500 response code is thrown which is an dead code and will never get executed. so remove it.

Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122603

Changed in heat:
status: New → In Progress
Revision history for this message
Steven Hardy (shardy) wrote :

FWIW I put that else there deliberately, so we return an appropriate error response if anyone ever updates ACTIONS without adding a new conditional. I suppose it's dead code, but on balance I see no disadvantage to leaving it there.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Kanagaraj Manickam (<email address hidden>) on branch: master
Review: https://review.openstack.org/122603
Reason: Abandoning this change set as reviewers felt that, its does no add much value at this moment !.

Changed in heat:
status: In Progress → Triaged
Changed in heat:
assignee: Kanagaraj Manickam (kanagaraj-manickam) → Pankaj Mishra (pankaj-mishra)
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308870

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Rico Lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/308870
Reason: Hi, this patch stays untouched for few months, would like to abandon for now. Feel free to restore it if you still working on this. Thank you!

Rico Lin (rico-lin)
Changed in heat:
milestone: none → no-priority-tag-bugs
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.