software_config and software_deployment tables lack a deleted_at column

[Kanagaraj Manickam]

the cloumn 'deleted_at' is used in the tables for representing the deleted time and to support soft delete. Once soft delete is provided, admin will run the db_archive command to remove the soft deleted rows on as per the admin schedule.

In heat, following tables are missing with deleted_at column.
Software_config
Software_deployment
user_Creds
raw_template
resource
event
snapshot
resource_data

[Clint Byrum (clint-fewbar)]

I do not believe there is a need for deleted_at on most of these tables. Some have a stack_id or a direct relationship with a table that has a stack_id. The records will effectively vanish from the public API when the stack is marked as deleted. Others, such as raw_template and user_creds, are referred to directly in the stack record and thus may be 1:N and will be cleaned up when the stack is archived and there are no more references to them.

So only software_config and software_deployment are in need of deleted_at.

[Steven Hardy (shardy)]

I agree with Clint, the only reason stack records are soft deleted is to enable events to be persisted for audit purposes, all of the resource related DB data should simply be deleted, we really don't want to start soft-deleting everything IMO.

[Kanagaraj Manickam (kanagaraj-manickam)]

Steven & Clint,

Thanks. I think, in addition to the software config tables, the raw_template table should be having the deleted_at, as during the auditing, it will be helpful to say that stack has gone thru changes from one template to another template as part of stack update. In the existing model, the old raw_template is not marked as deleted when the stack is updated from one template to new template.

[Steve Baker (steve-stevebaker)]

At the moment I don't think the software_config and software_deployment tables need to switch to soft delete. Configs are quite ephemeral, and anything can be discovered about a deployment before its stack is deleted.

We can always revisit this in the future, but it should be driven by an actual use case.

[Zane Bitter (zaneb)]

I agree with Clint and Steve H that user_creds, resource, event, snapshot and resource_data are deleted when the stack is deleted, and do not require soft delete.

It would probably be a good idea to do a (hard) delete of the old raw_template after doing a stack update, but there's absolutely no need to do a soft delete because they will also be cleaned up when the stack is eventually hard-deleted.

I also agree with Steve B that software_config and software_deployment don't require soft delete at this stage.