Docstrings missing for some methods in heat/db/sqlalchemy/api.py
Bug #1342131 reported by
Divakar Padiyar Nandavar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Triaged
|
Low
|
Shashwat Srivastava |
Bug Description
While reviewing one of the check-ins found that Docstrings is missing for some methods in heat/db/
Changed in heat: | |
assignee: | nobody → Divakar Padiyar Nandavar (divakar-padiyar-nandavar) |
Changed in heat: | |
importance: | Undecided → Low |
Changed in heat: | |
status: | New → Triaged |
Changed in heat: | |
milestone: | none → no-priority-tag-bugs |
To post a comment you must log in.
And neither does: https:/ /github. com/openstack/ heat/blob/ master/ heat/db/ api.py
but they are all *so* obvious, I just think this would be a waste of coding/reviewing time adding them.
for instance: /github. com/openstack/ heat/blob/ master/ heat/db/ sqlalchemy/ api.py# L111
https:/
def resource_ get_by_ name_and_ stack(context, resource_name, stack_id):
"""Get a resource by name and stack_id."""
Even if you fluff this out, you are really not adding any value, they are really painfully
obvious what they do.