AWS::EC2::Volume must not support any updates

Bug #1340093 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Pavlo Shchelokovskyy

Bug Description

According to AWS docs AWS::EC2::Volume resource does not support any updates [1]. Our current AWS-compatible resource in Heat supports volume size extension (my fault actually).

In order to align our resource with AWS the volume extension logic must be moved to native OS::Cinder::Volume resource and AWS::EC2::Volume must be made not updateable at all.

As the addition of update logic happened after Icehouse release, this can be done without deprecation period.

[1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html

Changed in heat:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106622

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/106622
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f50738ffcdc58f3814efbff7d7b1095ee5549cf1
Submitter: Jenkins
Branch: master

commit f50738ffcdc58f3814efbff7d7b1095ee5549cf1
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Jul 9 18:34:38 2014 +0300

    Move size update to Cinder volume

    In order to align AWS compatible Volume resource with current AWS
    behavior [1], this patch moves volume size extension to the native Cinder
    Volume resource.

    [1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html

    Change-Id: Ie1410d98175e1e42a95ca0fba72c48ca643a0dc7
    Partial-Bug: #1340093

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/112274
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a08dcd796fa1768becdcce0a4c77c0f15245dd8d
Submitter: Jenkins
Branch: master

commit a08dcd796fa1768becdcce0a4c77c0f15245dd8d
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Aug 6 14:34:13 2014 +0300

    Deny updates to AWS::EC2::Volume resource

    According to AWS docs [1] Volume resource does not support updates
    (including resource replacement) of any of its properties.
    To align our AWS-compatible resource with such behavior, all properties
    of AWS::EC2::Volume resource are marked as immutable.

    [1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html

    Change-Id: I7fea68f11c58d395c1eb31fae834afcab5dc4d1e
    Closes-Bug: #1340093

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.