logging during delete stack reports running an task from None

[Rakesh H S]

Severity: Low

created an stack using http://git.openstack.org/cgit/openstack/heat-templates/plain/hot/F20/WordPress_Native.yaml

While analyzing logs to find the sequence of operations that heat performs, found an flaw in log, wherein it says running an task from None!

i.e.
-------------------------------------------------------------

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None starting[00m [00;33mfrom (pid=9189) start /opt/stack/heat/heat/engine/scheduler.py:154[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

--------------------------------------------------------------

Snippet of log for stack-delete:
---------------------------------------------------------------
[00;36mINFO heat.engine.parser [[00;36m-[00;36m] [01;35m[00;36mStack DELETE IN_PROGRESS (teststack): Stack DELETE started[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask DependencyTaskGroup((destroy) {Server "wordpress_instance" [9ae39df1-e589-4bac-8632-5ff048ac2a84] Stack "teststack" [9944be21-d23d-42b5-94e8-729407be6ac0]: {}}) starting[00m [00;33mfrom (pid=9189) start /opt/stack/heat/heat/engine/scheduler.py:154[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask DependencyTaskGroup((destroy) {Server "wordpress_instance" [9ae39df1-e589-4bac-8632-5ff048ac2a84] Stack "teststack" [9944be21-d23d-42b5-94e8-729407be6ac0]: {}}) running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None starting[00m [00;33mfrom (pid=9189) start /opt/stack/heat/heat/engine/scheduler.py:154[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m
[00;36mINFO heat.engine.resource [[00;36m-[00;36m] [01;35m[00;36mdeleting Server "wordpress_instance" [9ae39df1-e589-4bac-8632-5ff048ac2a84] Stack "teststack" [9944be21-d23d-42b5-94e8-729407be6ac0][00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server starting[00m [00;33mfrom (pid=9189) start /opt/stack/heat/heat/engine/scheduler.py:154[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server sleeping[00m [00;33mfrom (pid=9189) _sleep /opt/stack/heat/heat/engine/scheduler.py:131[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server sleeping[00m [00;33mfrom (pid=9189) _sleep /opt/stack/heat/heat/engine/scheduler.py:131[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server sleeping[00m [00;33mfrom (pid=9189) _sleep /opt/stack/heat/heat/engine/scheduler.py:131[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m

[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask delete_server complete[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:193[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask DependencyTaskGroup((destroy) {Server "wordpress_instance" [9ae39df1-e589-4bac-8632-5ff048ac2a84] Stack "teststack" [9944be21-d23d-42b5-94e8-729407be6ac0]: {}}) running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None running[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:187[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask destroy from None complete[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:193[00m
[00;32mDEBUG heat.engine.scheduler [[00;36m-[00;32m] [01;35m[00;32mTask DependencyTaskGroup((destroy) {Server "wordpress_instance" [9ae39df1-e589-4bac-8632-5ff048ac2a84] Stack "teststack" [9944be21-d23d-42b5-94e8-729407be6ac0]: {}}) complete[00m [00;33mfrom (pid=9189) step /opt/stack/heat/heat/engine/scheduler.py:193[00m

[00;36mINFO heat.engine.parser [[00;36m-[00;36m] [01;35m[00;36mStack DELETE COMPLETE (teststack): Stack DELETE completed successfully[00m------------------------------------------------------------------

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/175752

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/175752
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2213bd0d90f6518e61aea8a9035c408052fa453e
Submitter: Jenkins
Branch: master

commit 2213bd0d90f6518e61aea8a9035c408052fa453e
Author: Limor Stotland <email address hidden>
Date: Sun Apr 26 15:45:07 2015 +0000

    Fix logging during delete stack

       *Wrap resource.Resource.destroy

    Change-Id: I9295870c95fe0cbd95107cb41d387a8da98287ec
    Closes-Bug: #1339759

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/253762

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/253762
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=242b06664f6170d000dccc2f3eb3b4e19a5c3f1a
Submitter: Jenkins
Branch: master

commit 242b06664f6170d000dccc2f3eb3b4e19a5c3f1a
Author: Zane Bitter <email address hidden>
Date: Fri Dec 4 20:58:18 2015 -0500

    Improve log messages from scheduler

    Ensure that an unbound method is never logged as "<method name> from None".

    Also report the actual action name when doing stack_action().

    Change-Id: Iff37860525d182e6eee01a7cc52c6599f05bff8c
    Related-Bug: #1339759