--marker behavior broken for stack-list

Bug #1332611 reported by Steve McLellan
34
This bug affects 7 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Zane Bitter

Bug Description

heatclient relies on --marker when the dashboard's listing stacks, because it doesn't know if the API has artificially limited the number of results it can request in one go.

https://review.openstack.org/#/c/96925 is the culprit; since then, 'marker' seems to be ignored and the same set of results is returned over and over.

To repro:

* create one or more stacks
* heat stack-list --limit N (where N is more than the number of stacks)

Reverting https://review.openstack.org/#/c/96925 fixes the behavior.

Steve McLellan (sjmc7)
Changed in heat:
assignee: nobody → Steve McLellan (sjmc7)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/101605

Changed in heat:
assignee: Steve McLellan (sjmc7) → Zane Bitter (zaneb)
status: New → In Progress
Steve McLellan (sjmc7)
Changed in heat:
assignee: Zane Bitter (zaneb) → nobody
Zane Bitter (zaneb)
Changed in heat:
importance: Undecided → High
assignee: nobody → Zane Bitter (zaneb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/101605
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b68e9dc62915a474783233a18888f8934f9d72ed
Submitter: Jenkins
Branch: master

commit b68e9dc62915a474783233a18888f8934f9d72ed
Author: Zane Bitter <email address hidden>
Date: Fri Jun 27 17:41:52 2014 -0400

    Fix pagination of stack-list

    This was broken by the refactor in dde5a81e8060b373982f165856071a80be1d40bb
    because the arguments to the DB call are in a different order to the ones
    in the API, presumably for historical reasons.

    Change-Id: I7503feb62089b252766a510281e0e4513945ad63
    Closes-Bug: #1332611

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.