wrong input of number parameter will result in abnormal behavior of heat

[xiejunan]

when i assign a wrong value to a number_typed parameter , heat will work not correctly.

heat stack-create mystack -f para_number_01.yaml -P"para_number=aaaa"

error message like this: ERROR, can not covert string to float "aaaa", this is ok. but it when cr-create the stack, it looks like the stack

has been created sucessfully. when i list stacks using stack-list command, the client will throw the same message and no stack will be listed.

[Thomas Herve (therve)]

I can't reproduce it. It does fail with an error, and the stack is not created.

[xiejunan (xiejunan)]

i re-cloned the code today. commands and corresponding messages just like:
heat stack-create mystack -f para_number.yaml -P"para_number=aaaa"
=>ERROR cloud not convert string to float: aaaa
heat stack-list
=>ERROR: cloud not convert string to float: aaaa
heat stack-create mystack -f para_number.yaml -P"para_number=80"
=>ERROR: the Stack(mystack) already exists.
heat stack-delete mystack
=>ERROR: cloud not convert string to float: aaaa
heat stack-create mystack -f para_number.yaml -P"para_number=8080"
=>create mystack sucessfully.

[Sergey Kraynev (skraynev)]

I can not reproduce this problem too. Could you say what version of heat do you use?

[xiejunan (xiejunan)]

my heat version: 0.2.9.13

[Haiyang DING (dinghaiyang)]

I can reproduce this one. When the input parameter does not satisfy the input constraint (using same command with xiejunan), it returns with:

ERROR: cloud not convert string to float: aaaa

which is fine.

However, when I use "heat stack-list" it says again:

ERROR: cloud not convert string to float: aaaa

which is not OK.

Further, when I try to create a new stack called "Test" (this choice is reasonable since the last "mystack" creation is supposed to be a failure thus does not exist), it returns with:

ERROR: The stack (mystack) already exists.

which is not OK.

There must be something wrong around here.

Now I have to ./unstack.sh + ./stack.sh to recover...

[Sergey Kraynev (skraynev)]

xiejunan: It's version of python-heatclient. My question was about heat project: it may be havana, icehouse, master and etc.

Haiyang DING: same question about release version of heat (not heatclient).

I use master and don't see such problem.

[Sergey Kraynev (skraynev)]

I have tried to reproduce it on icehouse release and have not got any error again.

@xiejunan, Haiyang DING: Could you provide more information about your deployments and how you got this error.
(May be heat-engine and heat-api logs be useful)

[xiejunan (xiejunan)]

i will check my environment as fast as possible.

[xiejunan (xiejunan)]

para_number_01.yaml :
heat_template_version: 2013-05-23
description: Simple template to deploy a single compute instance
parameters:
 para_number:
   type: number
   label: test number
   description: number description
   default: 80
   hidden: false

resources:
 my_instance1:
  type: OS::Nova::Server
  properties:
   key_name: heat_key
   image: cirros-0.3.1-x86_64-uec
   flavor: m1.tiny

outputs:
  ip_address:
    description: ip address
    value: { get_attr: [my_instance1,first_address]}
  para_number:
    description: para_number
    value: { get_param: para_number }
=================================

resources do not use this parameter.

[xiejunan (xiejunan)]

trace stack:
File "/opt/stack/heat/heat/openstack/common/rpc/amqp.py", line 462, in _process_data
   **args)
  File "/opt/stack/heat/heat/openstack/common/rpc/dispatcher.py", line 172, in dispatch
    result = getattr(proxyobj, method)(ctxt, **kwargs)
   File "/opt/stack/heat/heat/engine/service.py", line 62, in wrapped
    return func(self, ctx, *args, **kwargs)
  File "/opt/stack/heat/heat/engine/service.py", line 438, in list_stacks
 return list(format_stack_details(stacks))
 File "/opt/stack/heat/heat/engine/service.py", line 433, in format_stack_details
   yield api.format_stack(stack)
  File "/opt/stack/heat/heat/engine/api.py", line 91, in format_stack
    api.STACK_PARAMETERS: stack.parameters.map(str),
 File "/opt/stack/heat/heat/engine/parameters.py", line 434, in map
   for n, p in self.params.iteritems() if filter_func(p))
  File "/opt/stack/heat/heat/engine/parameters.py", line 434, in <genexpr>
 for n, p in self.params.iteritems() if filter_func(p))
  File "/opt/stack/heat/heat/engine/parameters.py", line 259, in __str__
   value = self.value()
  File "/opt/stack/heat/heat/engine/parameters.py", line 284, in value
  return float(self)
 File "/opt/stack/heat/heat/engine/parameters.py", line 275, in __float__
   return float(super(NumberParam, self).value())
ValueError: could not convert string to float: aaaa

[Sergey Kraynev (skraynev)]

@xiejunan: Thanks. Now I can reproduce it with provided template.

[xiejunan (xiejunan)]

i think i have found the reason:

heat/engine/parameters.py class NumberParam

 def _validate(self, val, context):
        self.schema.validate_value(self.name, val, context)
        #added by xiejunan : constraint checking is not enough, try to get value of number
        self.value()

[Sergey Kraynev (skraynev)]

@xiejunan: If you sure, that it works, please upload a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96390

[Ethan Lynn (ethanlynn)]

Sorry I didn't notice this bug and open a new bug https://bugs.launchpad.net/heat/+bug/1329152
and upload a patch to fix this.

[Ethan Lynn (ethanlynn)]

My patch is also in review:
https://review.openstack.org/#/c/99561/

[Steven Hardy (shardy)]

The proposed patch has negative feedback which has not been addressed in over a month. Bumping to J3.

[xiejunan (xiejunan)]

Ethan Lyunn has fixed this bug. this bug can be abandoned.

[Angus Salkeld (asalkeld)]

I think there is a missing part to this bug:
stack-list should never fail on a validation error.

$ heat stack-list
'stacks'

heat-api log:

JSON response : {"explanation": "The server could not comply with the request since it is either malformed or otherwise incorrect.", "code": 400, "error": {"message": "The Parameter (image) was not defined in template.", "traceback": "Traceback (most recent call last):\n\n File \"/opt/stack/heat/heat/engine/service.py\", line 63, in wrapped\n return func(self, ctx, *args, **kwargs)\n\n File \"/opt/stack/heat/heat/engine/service.py\", line 458, in list_stacks\n return [api.format_stack(stack) for stack in stacks]\n\n File \"/opt/stack/heat/heat/engine/stack.py\", line 251, in load_all\n yield cls._from_db(context, stack, resolve_data=resolve_data)\n\n File \"/opt/stack/heat/heat/engine/stack.py\", line 268, in _from_db\n use_stored_context=use_stored_context)\n\n File \"/opt/stack/heat/heat/engine/stack.py\", line 113, in __init__\n context=self.context)\n\n File \"/opt/stack/heat/heat/engine/parameters.py\", line 437, in validate\n self._validate_user_parameters()\n\n File \"/opt/stack/heat/heat/engine/parameters.py\", line 480, in _validate_user_parameters\n raise exception.UnknownUserParameter(key=param)\n\nUnknownUserParameter: The Parameter (image) was not defined in template.\n", "type": "UnknownUserParameter"}, "title": "Bad Request"} from (pid=27501) to_json /opt/stack/heat/heat/common/serializers.py:43

stack-list should say
stack-X | unparsable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110536

[OpenStack Infra (hudson-openstack)]

Change abandoned by Angus Salkeld (<email address hidden>) on branch: master
Review: https://review.openstack.org/110536
Reason: there is an equivalent patch in already.

[Angus Salkeld (asalkeld)]

https://github.com/openstack/heat/commit/acf39978ad91bb6d49cb23459f0c521f3262afac

[OpenStack Infra (hudson-openstack)]

Change abandoned by Angus Salkeld (<email address hidden>) on branch: master
Review: https://review.openstack.org/96390
Reason: adandoning old reviews, feel free to repost this if you want to get it merged.