Invalid engine server resource validation does not work with nova Noopquotadriver

[Vladimir Kuklin]

How to reproduce:

Deploy openstack with Nova configured to use NoopQuotaDriver.
Try to create simple stack, e.g. use this as template file contents:

{
  "AWSTemplateFormatVersion": "2010-09-09",
  "Outputs": {},
  "Description": "Hadoop Cluster by Sahara",
  "Resources": {
    "instance1": {
      "Type": "OS::Nova::Server",
      "Properties": {
        "name": "instance1",
        "flavor": "1",
        "image": "af72cf5c-02f5-4260-a181-da7331b58ca2"
      }
    }
  }
}

The problem is for example here:

https://github.com/openstack/heat/blob/stable/icehouse/heat/engine/resources/server.py#L945-L949

It is easy to see that in case of '-1's returned by nova NoopQuotaDriver, even empty values will exceed the quota.

The workaround is to either change the quota driver to DbQuotaDriver or to comment out these checks.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/89388

[Timur Nurlygayanov (tnurlygayanov)]

Looks like we can fix this issue only in Heat and after that use the correct Heat version to fix this issue in other components.
Can we remove Murano from the list of related projects?

[Timur Nurlygayanov (tnurlygayanov)]

This bug will be fixed in Heat and Murano will use new version of Heat. No changes in Murano needed to fix this issue.

[Max Rasskazov (mrasskazov)]

Change request http://gerrit.mirantis.com/14832

[Sergey Lukjanov (slukjanov)]

It's not related to Sahara.

[Max Rasskazov (mrasskazov)]

https://gerrit.mirantis.com/#/c/14832/

[Clint Byrum (clint-fewbar)]

Note that I believe this bug was caused by unclear Nova docs.

https://bugs.launchpad.net/openstack-api-site/+bug/1316381

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/89389
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ea5285fd5080e5fec20a8763ef98e6ffa9c7dea1
Submitter: Jenkins
Branch: master

commit ea5285fd5080e5fec20a8763ef98e6ffa9c7dea1
Author: Vladimir Kuklin <email address hidden>
Date: Mon Apr 21 21:42:14 2014 +0400

    Ignore nova limits set to '-1'

    In case nova server has quotas turned off, e.g. when it uses
    NoopQuotaDriver, nova-api returns '-1' for corresponding resources which
    obviously means 'INFINITY'. In this case we should not check resource
    template for any limits and should pass resource creation as-is.

    Change-Id: Idaf485719e384f3a613031c7ff272d55798e6e77
    Closes-Bug: #1310710
    Co-Authored-By: Dmitry Borodaenko <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/89388
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=937ac5a0894719af21cfac24e218a980307fceed
Submitter: Jenkins
Branch: stable/icehouse

commit 937ac5a0894719af21cfac24e218a980307fceed
Author: Vladimir Kuklin <email address hidden>
Date: Mon Apr 21 21:42:14 2014 +0400

    Ignore nova limits set to '-1'

    In case nova server has quotas turned off, e.g. when it uses
    NoopQuotaDriver, nova-api returns '-1' for corresponding resources which
    obviously means 'INFINITY'. In this case we should not check resource
    template for any limits and should pass resource creation as-is.

    Change-Id: Idaf485719e384f3a613031c7ff272d55798e6e77
    Closes-Bug: #1310710
    Co-Authored-By: Dmitry Borodaenko <email address hidden>