Error deleting deleted stack project

[Steve Baker]

If heat-engine is terminated mid-delete, a stack could become undeletable because of NotFound exceptions being raised on keystone delete stack domain operations.

Attempting to delete the project in delete_stack_domain_project should tolerate 404s

2014-04-17 13:44:39.654 ERROR heat.engine.parser [-] Could not find project, e2f4b78a560a4a3d9ee6df7e313ad160. (HTTP 404)
2014-04-17 13:44:39.654 TRACE heat.engine.parser Traceback (most recent call last):
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/heat/heat/engine/parser.py", line 682, in delete
2014-04-17 13:44:39.654 TRACE heat.engine.parser project_id=self.stack_user_project_id)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/heat/heat/common/heat_keystoneclient.py", line 395, in delete_stack_domain_project
2014-04-17 13:44:39.654 TRACE heat.engine.parser self.domain_admin_client.projects.delete(project=project_id)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/v3/projects.py", line 98, in delete
2014-04-17 13:44:39.654 TRACE heat.engine.parser project_id=base.getid(project))
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/base.py", line 66, in func
2014-04-17 13:44:39.654 TRACE heat.engine.parser return f(*args, **new_kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/base.py", line 360, in delete
2014-04-17 13:44:39.654 TRACE heat.engine.parser self.build_url(dict_args_in_out=kwargs))
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/base.py", line 197, in _delete
2014-04-17 13:44:39.654 TRACE heat.engine.parser return self.client.delete(url)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/httpclient.py", line 605, in delete
2014-04-17 13:44:39.654 TRACE heat.engine.parser return self._cs_request(url, 'DELETE', **kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/httpclient.py", line 582, in _cs_request
2014-04-17 13:44:39.654 TRACE heat.engine.parser return self.request(url, method, **kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/httpclient.py", line 564, in request
2014-04-17 13:44:39.654 TRACE heat.engine.parser resp = super(HTTPClient, self).request(url, method, **kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/baseclient.py", line 21, in request
2014-04-17 13:44:39.654 TRACE heat.engine.parser return self.session.request(url, method, **kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/utils.py", line 318, in inner
2014-04-17 13:44:39.654 TRACE heat.engine.parser return func(*args, **kwargs)
2014-04-17 13:44:39.654 TRACE heat.engine.parser File "/home/steveb/dev/localstack/python-keystoneclient/keystoneclient/session.py", line 251, in request
2014-04-17 13:44:39.654 TRACE heat.engine.parser raise exceptions.from_response(resp, method, url)
2014-04-17 13:44:39.654 TRACE heat.engine.parser NotFound: Could not find project, e2f4b78a560a4a3d9ee6df7e313ad160. (HTTP 404)
2014-04-17 13:44:39.654 TRACE heat.engine.parser

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88490

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88490
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=7752f649248bb1d31ad5629a9b66f2884004d192
Submitter: Jenkins
Branch: master

commit 7752f649248bb1d31ad5629a9b66f2884004d192
Author: Steve Baker <email address hidden>
Date: Fri Apr 18 15:52:40 2014 +1200

    Catch NotFound for keystone delete operations

    If heat-engine is terminated mid-delete, a stack could become
    undeletable because of NotFound exceptions being raised on keystone
    delete stack domain operations.

    This change wraps all keystone delete calls and ignores any NotFound
    exceptions raised.

    Change-Id: I032b04b1391590a6f9493b65bddff331b07722f0
    Closes-Bug: #1308812

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/95921

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95921
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3c560c6bacc4b25b9303aed23ddd6205c6ee7e4c
Submitter: Jenkins
Branch: stable/icehouse

commit 3c560c6bacc4b25b9303aed23ddd6205c6ee7e4c
Author: Steve Baker <email address hidden>
Date: Fri Apr 18 15:52:40 2014 +1200

    Catch NotFound for keystone delete operations

    If heat-engine is terminated mid-delete, a stack could become
    undeletable because of NotFound exceptions being raised on keystone
    delete stack domain operations.

    This change wraps all keystone delete calls and ignores any NotFound
    exceptions raised.

    Change-Id: I032b04b1391590a6f9493b65bddff331b07722f0
    Closes-Bug: #1308812