Using new attribute Schema class for each attribute such as for properties

Bug #1307319 reported by Sergey Kraynev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Sergey Kraynev

Bug Description

At now we have Schema class for attribute and should use it for all attributes such as for properties:

attributes_schema = {
       'attr_name': attributes.Schema(
             'Description')
}

Changed in heat:
assignee: nobody → Sergey Kraynev (skraynev)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89331

Changed in heat:
status: Triaged → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/89332

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/89553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/89331
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e01251b6058481d08a51e9566b603f6bf5f24913
Submitter: Jenkins
Branch: master

commit e01251b6058481d08a51e9566b603f6bf5f24913
Author: Sergey Kraynev <email address hidden>
Date: Fri Apr 18 09:15:00 2014 -0400

    Using new attribute schema for all resources

    Currently resources use old style of attribute schema. For example:

        attribute_name: _('Description')

    This patch contains changes to migrate for new attribute Schema class.
    For example:

        attribute_name: attributes.Schema(_('Descriprion'))

    Partial-Bug: #1307319

    Change-Id: I54c7b9d481655b0051d0f7ff668672011ac882e9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/89332
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2d31330ade6dc0536aba820e5b98905c2178107d
Submitter: Jenkins
Branch: master

commit 2d31330ade6dc0536aba820e5b98905c2178107d
Author: Sergey Kraynev <email address hidden>
Date: Mon Apr 21 06:41:08 2014 -0400

    Make attributes definition similar on properties

    Current attributes_schema contains hard codeded names of attributes.
    This patch replaces all hard coded names on variables defined in
    ATTRIBUTE tuple.

    Change-Id: I1ea7b33bd598dba07f2190c282497c573463b0dd
    Partial-Bug: #1307319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/89553
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=be26f4089eb51b84a455057aaddbcb2f2cbbc57c
Submitter: Jenkins
Branch: master

commit be26f4089eb51b84a455057aaddbcb2f2cbbc57c
Author: Sergey Kraynev <email address hidden>
Date: Tue Apr 22 08:20:01 2014 -0400

    Deprecating the old style attribute Schema

    There is last patch to migrate on new attribute Schema.
    The main changes are:
     - Deprecation warning was added in from_attribute function.
       If attribute have old format, it will be converted to new schema format
       and Deprecation warning will be raised.
     - Translation to new Schema was added in function schema_from_outputs.
     - All generic resources have been changed and use new Schema class now.
     - Some others tests have been fixed and use new Schema class now.

    Change-Id: Icf92f2d275a86a13c656b0e74b725a442db3e532
    Closes-Bug: #1307319

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.