Wrongly printed count of received handled conditions

Bug #1297230 reported by Ladislav Smola
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Dimitri Mazmanov

Bug Description

https://github.com/openstack/heat/blob/master/heat/engine/resources/wait_condition.py#L139

reasons = handle.get_status_reason(STATUS_SUCCESS)
vals = {'len': len(reasons),

len(reasons) actually gets len of string, so the message below is wrong: message = (_('%(len)d of %(count)d received - %(reasons)s') % vals)

so reasons should be obtained like handle.get_status() like it is done for checking the condition at:

https://github.com/openstack/heat/blob/master/heat/engine/resources/wait_condition.py#L229

Ladislav Smola (lsmola)
description: updated
Ladislav Smola (lsmola)
description: updated
Changed in heat:
assignee: nobody → Dimitri Mazmanov (sorantis)
Changed in heat:
status: New → Fix Committed
Revision history for this message
Sergey Kraynev (skraynev) wrote :

Dmitri, please add link on this bug in commit message (look Liang's comment). More information here (https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references)

If you do it, the status of bug automatically will go to In progress.
When your fix will be merged status automatically (again) will change to Fix Committed.

Changed in heat:
status: Fix Committed → Incomplete
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/87293

Revision history for this message
Dimitri Mazmanov (sorantis) wrote :

Sergey, thanks for the link. I guess now I got the process right :)
I've also started everything again, so the first attempt is obsolete now.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/87293
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a4ed4a1921a3da3b5cf14970fcd88096f8595e51
Submitter: Jenkins
Branch: master

commit a4ed4a1921a3da3b5cf14970fcd88096f8595e51
Author: Dimitri Mazmanov <email address hidden>
Date: Mon Apr 14 17:08:19 2014 +0200

    Fix wrongly printed count of received handled conditions.

    The WaitConditionTimeout message was using size of the reason
    string as input instead of the actual number of status reasons.

    Change-Id: I9ad1813755eda6924ffeff116eaeda9f36b601d1
    Closes-Bug: #1297230

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-1
status: Fix Committed → Fix Released
tags: added: icehouse-backport-potential
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.