stack-list throws an error if any stack returned contains a template error

Bug #1296859 reported by Paul Nelson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steven Dake

Bug Description

Now that template information is being verified, it is possible that old templates created before validation are now considered invalid. If any of stacks were made with a template that is now considered invalid, python-heatclient fails to show anything on stack-list except for an error (using python-heatclient v0.2.8):

ERROR: "2014-03-07" is not a valid heat_template_version. Should be one of: ('2013-05-23',)

Only the error is shown, even though there are many other templates that are fine and should be shown.

Revision history for this message
Randall Burt (randall-burt) wrote :

Seems that we may want to skip template validation all together on a stack-list.

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

This is really a heat problem

no longer affects: python-heatclient
Changed in heat:
milestone: none → icehouse-rc1
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Steven Dake (sdake) wrote :

I'll investigate removing template validation on stack-list and stack-delete (sbaker's idea). Not really sure we can do much about the update case, since we need validation on update, yet an update of an old stack with the new code will still result in this problem.

Changed in heat:
assignee: nobody → Steven Dake (sdake)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83241

Changed in heat:
status: Triaged → In Progress
Revision history for this message
Steven Dake (sdake) wrote :

Resolution involved a database migration rather than reworking the parsers into a separate validate and parse operation. Long term we might want to think about separating the parsers into these two separate operations, or we may not want to do that :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/83241
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b4f14d6e5f19e64e160e224fd7140629729e1666
Submitter: Jenkins
Branch: master

commit b4f14d6e5f19e64e160e224fd7140629729e1666
Author: Steven Dake <email address hidden>
Date: Wed Mar 26 16:04:51 2014 -0700

    Migrate invalid template version values

    If a stack was created with a template that specified an invalid time,
    a variety of operations cannot be done on the stack, resulting in a
    general breakage of Heat. This patch migrates any occurances of version
    numbers that are invalid that were specified prior to the merging of this
    patch. This patch also handles invalid version fields where a non-date
    is specified or an invalid date was specified.

    Change-Id: I5387ffb84dba5160103b3cb02f3d1cc5f352ff29
    Closes-bug: 1296859

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.