Heat software orchestration ignores software config if user_data_format is missing

[Thomas Spatzier]

The current design/implementation of HOT software orchestration applies software configs to servers when those software configs are associated to a server via a SoftwareDeployment resource. However, it is also required that the user_data_format of the server is set to 'SOFTWARE_CONFIG' - otherwise, the software configs will be ignored.

This is unintuitive for template writers. As a template writer, I would expect that the fact that I associate a software config via a software deployment to a server is enough. So it should not be required to also set the user_data_format attribute.

[Clint Byrum (clint-fewbar)]

Agreed. Starting to use it and this just seems like a missed detail. Easily corrected though.

[Steve Baker (steve-stevebaker)]

This could only be validated by looking up the server resource from the deployment validate method. Its messy but I suppose its the only option.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82992

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/82992
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=09a7d80b31e989b272c7a3d5991c84688ad6017b
Submitter: Jenkins
Branch: master

commit 09a7d80b31e989b272c7a3d5991c84688ad6017b
Author: JUNJIE NAN <email address hidden>
Date: Wed Mar 26 13:32:54 2014 +0800

    Validate user_data_format for server with deployment

    Validation error will be raised if user_data_format is not set
    correctly.

    Partial-Bug: #1295536
    Change-Id: I0509c9c3a71d09fa8e2113710d561ffd3289d814

[Steven Hardy (shardy)]

Jun Jie, can you confirm, is the fix above the full fix for this bug, or are we expecting additional patches?

If it's completed, please you you update the status to fix committed (or fix released and remove the milestone target if it's already been released)

[Thomas Spatzier (thomas-spatzier)]

IIRC, Jun Jie's patch only raise a validation error when the user_data_format property was missing or did not match the SOFTWARE_CONFIG value even though SoftwareDeployments were associated to a server. A more convenient solution IMO would be to just assume that value whenever SotwareDeployments are associated.

[Steve Baker (steve-stevebaker)]

This check has to happen via REST API calls rather than by calling stack.resource_by_refid in the validate method. I'm not sure what you could set on the nova server to store the user_data_format - maybe you could set/get a nova meta key/value