TheadGroupManager.start_with_acquired_lock does not pass keyword arguments to the function being started

Bug #1288627 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Pavlo Shchelokovskyy

Bug Description

It went unnoticed since we did not launch any functions requiring kwargs with it so far. I stumbled upon it when working on blueprint on cancelling of stack update. Also the ThreadGroupManager lacks unit tests, which also contributed to this mistake not being caught earlier.

Changed in heat:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Changed in heat:
status: New → In Progress
Changed in heat:
importance: Undecided → High
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/76251
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0f8be1dbcf9e641d5192fc5ce85990fd580083a0
Submitter: Jenkins
Branch: master

commit 0f8be1dbcf9e641d5192fc5ce85990fd580083a0
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Feb 25 15:52:47 2014 +0000

    Fix start_with_acquired_lock - pass kwargs to func

    This method of ThreadGroupManager was not passing kwargs
    to the function to be started.

    Closes-Bug: #1288627
    Change-Id: Icaaa012bcc65c67f3e8ecc2878dee2a78121e357

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/78286
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=16840f8585034f8fbe92b1420909da8d59e4fc2e
Submitter: Jenkins
Branch: master

commit 16840f8585034f8fbe92b1420909da8d59e4fc2e
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Mar 5 18:15:09 2014 +0200

    Add more unit tests for ThreadGroupManager

    this patch adds unit tests for the rest of ThreadGroupManager methods.
    Related-Bug: #1288627
    Change-Id: I38a0864c649d1693ef4fb5b49d5aeb37632263ca

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.