TheadGroupManager.start_with_acquired_lock does not pass keyword arguments to the function being started
Bug #1288627 reported by
Pavlo Shchelokovskyy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Fix Released
|
High
|
Pavlo Shchelokovskyy |
Bug Description
It went unnoticed since we did not launch any functions requiring kwargs with it so far. I stumbled upon it when working on blueprint on cancelling of stack update. Also the ThreadGroupManager lacks unit tests, which also contributed to this mistake not being caught earlier.
Changed in heat: | |
assignee: | nobody → Pavlo Shchelokovskyy (pshchelo) |
Changed in heat: | |
status: | New → In Progress |
Changed in heat: | |
importance: | Undecided → High |
milestone: | none → icehouse-rc1 |
Changed in heat: | |
status: | Fix Committed → Fix Released |
Changed in heat: | |
milestone: | icehouse-rc1 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/76251 /git.openstack. org/cgit/ openstack/ heat/commit/ ?id=0f8be1dbcf9 e641d5192fc5ce8 5990fd580083a0
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0f8be1dbcf9e641 d5192fc5ce85990 fd580083a0
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Feb 25 15:52:47 2014 +0000
Fix start_with_ acquired_ lock - pass kwargs to func
This method of ThreadGroupManager was not passing kwargs
to the function to be started.
Closes-Bug: #1288627 7f3e8ecc2878dee 2a78121e357
Change-Id: Icaaa012bcc65c6