Comparison with singletons should use assertIs or assertIsNone in unittests
Bug #1259023 reported by
Ryo Miki
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Fix Released
|
Low
|
Pavlo Shchelokovskyy | ||
python-heatclient |
Fix Released
|
Low
|
Pavlo Shchelokovskyy |
Bug Description
This report is applying comments in below patch (patch set 4).
https:/
AssertEqual(None, AAA) should be AssertIsNone(AAA) in unittests
the same goes for True and False singletons, with appropriate usage of assertIs / assertIsNot
Changed in heat: | |
assignee: | nobody → Pavlo Shchelokovskyy (pshchelo) |
description: | updated |
summary: |
- AssertEqual(None, AAA) should be AssertIsNone(AAA) in unittests + Comparison with singletons shoif use assertIs or assertIsNone in + unittests |
description: | updated |
summary: |
- Comparison with singletons shoif use assertIs or assertIsNone in + Comparison with singletons should use assertIs or assertIsNone in unittests |
Changed in python-heatclient: | |
assignee: | nobody → Pavlo Shchelokovskyy (pshchelo) |
Changed in heat: | |
milestone: | none → icehouse-2 |
status: | Fix Committed → Fix Released |
Changed in python-heatclient: | |
importance: | Undecided → Low |
milestone: | none → v0.2.7 |
Changed in python-heatclient: | |
status: | Fix Committed → Fix Released |
Changed in heat: | |
milestone: | icehouse-2 → 2014.1 |
To post a comment you must log in.
One problem, one bug please.
- Check usage of AssertEqual( expected, observed). Some codes are AssertEqual( observed, expected).
Step #2 AssertIn is more prefeable then AssertTrue in text match cases.