parser.Stack only uses tenant_id from request context

[Richard Lee]

After parsing a stack from the database, we are not using the tenant information that we receive back from the db; instead, we are relying on the request context.tenant_id.

For example in parser.Stack.load, we grab the stack from the database, and we could instantiate the parser.Stack with the real stack's tenant_id rather than depending on the context.tenant_id later down the line (such as in Stack#identifier and Stack#store).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54446

[Steven Hardy (shardy)]

As mentioned in my comment on https://review.openstack.org/#/c/54446/, I get the logic behind this change, but can you please explain what actual issue you've observed prompting this change? Where is Stack#identifier and Stack#store used with the admin context?

The admin context should not every be used like that, so if it is, we may be missing some other underlying bug.

[Steven Hardy (shardy)]

s/every/ever/

[Steve Baker (steve-stevebaker)]

There has been so much change in that area of the code that I doubt the behaviour is still the same. Marking invalid for now unless there is some new information on what problem this actually causes.