HOT non-obvious validation error

Bug #1227061 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Sahdev Zala
Havana
Fix Released
Undecided
Unassigned

Bug Description

When doing the parameter conversion, the HOT parser can return a non-obvious internal error:

parameters:
  KeyName:
  type: string
    description: Name of an existing key pair to use for the instance

Gives 400 with "Template not in valid format"

But

parameters:
  KeyName:
    type: string
  description: Name of an existing key pair to use for the instance

Gives 400 with 'unicode' object has no attribute 'iteritems'

Steven Hardy (shardy)
Changed in heat:
milestone: none → havana-rc1
status: New → Triaged
importance: Undecided → Medium
Steven Hardy (shardy)
Changed in heat:
milestone: havana-rc1 → icehouse-1
Sahdev Zala (spzala)
Changed in heat:
assignee: nobody → Sahdev Zala (spzala)
Revision history for this message
Sahdev Zala (spzala) wrote :

In the second case, the "description" is a valid yaml syntax and considered as a parameter and so it doesn't run into any format invalid error, but it throws error while iterating 'description' value.

Changed in heat:
status: Triaged → In Progress
Steven Hardy (shardy)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/51433
Committed: http://github.com/openstack/heat/commit/782c5d939abe980585c5f549b956f1565408d004
Submitter: Jenkins
Branch: master

commit 782c5d939abe980585c5f549b956f1565408d004
Author: Sahdev Zala <email address hidden>
Date: Sat Oct 12 22:32:45 2013 -0500

    Validate template parameter attributes

    Validate that template parameter is provided with at least one attribute.

    Closes-Bug: #1227061

    Change-Id: I5e245556c21a1ea800eb9e0346f3b2414ad56183

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/56832

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/havana)

Reviewed: https://review.openstack.org/56832
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=35cfa39fb1f05ea94a2d244d231b2381783795d7
Submitter: Jenkins
Branch: stable/havana

commit 35cfa39fb1f05ea94a2d244d231b2381783795d7
Author: Sahdev Zala <email address hidden>
Date: Sat Oct 12 22:32:45 2013 -0500

    Validate template parameter attributes

    Validate that template parameter is provided with at least one attribute.

    Closes-Bug: #1227061

    Change-Id: I5e245556c21a1ea800eb9e0346f3b2414ad56183

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.