Activity log for bug #1226666

Date Who What changed Old value New value Message
2013-09-17 15:38:12 mouadino bug added bug
2013-09-18 07:37:04 mouadino description Hi, In Neutron the "gateway_ip" field of a subnet is treaded differently depending of wether it's was set by user to None or '' (Empty string) which respectively mean don't set a gateway ip for gateway_ip=None and choose first available ip as gateway ip in the case where it's set to empty string. Now from Heat perspective setting gateway_ip in the template to "null" or not setting it at all is the same thing i.e. heat will interpreter both cases as if gateway_ip was set to empty string which mean that there is no way right now to create a subnet from Heat with no gateway ip. Two possible fixes that i have in mind: 1- I tried to create a patch to enable using "null" as a value to gateway_ip and adding a new schema option AcceptNone (true or false) which IMHO sound to me like the correct way to handle this, but i found (the hard way) that Heat treat None and "not set" as the same thing and it rely heavily on this behavior which is very wrong and which mean to follow this step we will have to change a lot of code. 2- Another fix that can will be specific to this case only (gateway_ip) is to add a new resource Boolean property "no_gateway" and of course make sure that gateway_ip and this new property are mutually exclusive. Thanks, Hi, In Neutron the "gateway_ip" field of a subnet is treaded differently depending of wether it's was set by user to None or not given which respectively mean don't set a gateway ip for gateway_ip=None and choose first available ip as gateway ip in the case where it's not given. Now from Heat perspective if you set gateway_ip in the template to "null", heat will interpreter as if gateway_ip was set to empty string which will make Quantum raise an exception telling you that **'' is not a valid ip**, so AFAIK there is no way right now to create a subnet from Heat with no gateway ip. Two possible fixes that i have in mind: 1- I tried to create a patch to enable using "null" as a value to gateway_ip and adding a new schema option AcceptNone (true or false) which IMHO sound to me like the correct way to handle this (and any upcoming cases Where None as a special meaning), but i found (the hard way) that Heat treat None and "not set" as the same thing and it rely heavily on this behavior which is very wrong IMHO. 2- Another fix which is specific to this case only (gateway_ip) is to add a new resource Boolean property "no_gateway" and of course make sure that gateway_ip and this new property are mutually exclusive. Thanks,
2013-09-18 23:43:47 Steve Baker heat: status New Triaged
2013-09-18 23:43:50 Steve Baker heat: importance Undecided Medium
2013-09-18 23:43:53 Steve Baker heat: assignee Steve Baker (steve-stevebaker)
2013-09-23 08:38:06 mouadino description Hi, In Neutron the "gateway_ip" field of a subnet is treaded differently depending of wether it's was set by user to None or not given which respectively mean don't set a gateway ip for gateway_ip=None and choose first available ip as gateway ip in the case where it's not given. Now from Heat perspective if you set gateway_ip in the template to "null", heat will interpreter as if gateway_ip was set to empty string which will make Quantum raise an exception telling you that **'' is not a valid ip**, so AFAIK there is no way right now to create a subnet from Heat with no gateway ip. Two possible fixes that i have in mind: 1- I tried to create a patch to enable using "null" as a value to gateway_ip and adding a new schema option AcceptNone (true or false) which IMHO sound to me like the correct way to handle this (and any upcoming cases Where None as a special meaning), but i found (the hard way) that Heat treat None and "not set" as the same thing and it rely heavily on this behavior which is very wrong IMHO. 2- Another fix which is specific to this case only (gateway_ip) is to add a new resource Boolean property "no_gateway" and of course make sure that gateway_ip and this new property are mutually exclusive. Thanks, Hi, In Neutron the "gateway_ip" field of a subnet is treaded differently depending of wether it's was set by user to None or not given which respectively mean don't set a gateway ip for gateway_ip=None and choose first available ip as gateway ip in the case where it's not given. Now from Heat perspective if you set gateway_ip in the template to "null", heat will interpreter as if gateway_ip was set to empty string which will make Neutron raise an exception telling you that **'' is not a valid ip**, so AFAIK there is no way right now to create a subnet from Heat with no gateway ip. Two possible fixes that i have in mind: 1- I tried to create a patch to enable using "null" as a value to gateway_ip and adding a new schema option AcceptNone (true or false) which IMHO sound to me like the correct way to handle this (and any upcoming cases Where None has a special meaning), but i found (the hard way) that Heat treat None and "not set" as the same thing and it rely heavily on this behavior which is very wrong IMHO. 2- Another fix which is specific to this case only (i.e. gateway ip) is to add a new resource Boolean property "no_gateway" and of course make sure that gateway_ip and this new property are mutually exclusive. Thanks,
2013-09-24 21:23:09 Steve Baker heat: milestone havana-rc1
2013-09-24 21:24:34 Steve Baker heat: status Triaged In Progress
2013-09-27 08:21:22 OpenStack Infra heat: status In Progress Fix Committed
2013-10-03 09:08:50 Thierry Carrez heat: status Fix Committed Fix Released
2013-10-17 10:06:38 Thierry Carrez heat: milestone havana-rc1 2013.2