Should run all pyflakes and pep8 checks

Bug #1171616 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Invalid
Wishlist
Clint Byrum

Bug Description

Right now only a small subset of pyflakes is used on the code. We should follow other code bases' examples and use flake8 with as few disabled rules as possible.

Changed in heat:
assignee: nobody → Clint Byrum (clint-fewbar)
status: New → In Progress
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Wishlist
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Just to note:

Right now we already have only 3 style checks from oslo.hacking disabled in our tox.ini.

There is also a blueprint reduce-flake8-ignored-rules for it.

Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Actually there are only two left [1] already:
- check that there is no full stop in commit title
- check for proper multiline docstring formatting

Those are not code style per se, so I propose to close this bug already

[1] https://github.com/openstack/heat/blob/master/tox.ini#L51

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

We're down to ignore = H404,H405

I think this can be closed off.

Changed in heat:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.