Rollback deletes all events by default

[Zane Bitter]

Until such time as the blueprint https://blueprints.launchpad.net/heat/+spec/event-persistence is implemented, an error in stack creation with rollback enabled will cause all events and other stack data that could be used to debug the problem to be immediately deleted.

Since rollback is enabled by default, we're probably going to get a lot of unfortunate support requests. We should disable it by default until the blueprint has been implemented.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23421

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23422

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23423

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23421
Committed: http://github.com/openstack/heat/commit/7f9d593c98452a2c8f23d82f8bb504ae4c3a365c
Submitter: Jenkins
Branch: master

commit 7f9d593c98452a2c8f23d82f8bb504ae4c3a365c
Author: Steven Hardy <email address hidden>
Date: Mon Mar 4 11:57:56 2013 +0000

    heat engine : Disable stack rollback by default

    Until the event-persistence BP is implemented, we should
    disable stack rollback by default and make it opt-in.

    fixes bug 1131303

    Change-Id: I101e108c3959c4b7b4cfc68449ba2b989b157626

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23422
Committed: http://github.com/openstack/heat/commit/0aea9429bf122eb4cde1b749b129ecfe6ca8f63c
Submitter: Jenkins
Branch: master

commit 0aea9429bf122eb4cde1b749b129ecfe6ca8f63c
Author: Steven Hardy <email address hidden>
Date: Mon Mar 4 15:27:57 2013 +0000

    heat clients : Change --disable-rollback to --enable-rollback

    Since the engine default is now rollback disabled, flip this
    switch so the user can opt-in to rollback functionality via
    the --enable-rollback cli option to heat-cfn/heat-boto

    ref bug 1131303

    Change-Id: I3965de9a2beb510d5623d0c7cd8ff3aea9d4364a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23423
Committed: http://github.com/openstack/heat/commit/d02b0889c637c26b840939662d4d51358169b892
Submitter: Jenkins
Branch: master

commit d02b0889c637c26b840939662d4d51358169b892
Author: Steven Hardy <email address hidden>
Date: Mon Mar 4 15:29:36 2013 +0000

    heat clients : Make heat-boto rollback disabled by default

    The boto library always sends the DisableRollback parameter,
    defaulted to False, which is the opposite of the engine
    default now, so we have to set DisableRollback to True in
    the boto client wrapper

    ref bug 1131303

    Change-Id: I4acbba7b37f24cb1a874292ff2323ae24b630edf