heat: doesn't use EC2 tags API

[Stephen Gran]

in EC2, creating either an autoscaling group or a cloudformation stack will tag the instances with

aws:autoscaling:groupName: $stack_name-$resource_name-<alphanumeric>
aws:cloudformation:logical-id: $resource_name
aws:cloudformation:stack-id: arn:aws:cloudformation:$region_name:$account_name:stack/$stack_name/$stack_id
aws:cloudformation:stack-name: $stack_name

for just an autoscaling group not created as part of a cloudformation stack, only the first tag is automatically created.

The API used is the EC2 CreateTags call. This is distinct from the openstack metadata (I think) key/value pairs as tags do not appear in instance metadata. I have written a patch set to implement the *Tags calls in the openstack EC2 API, as well as the ability to search for instances by tags.

[Steven Hardy (shardy)]

Related links:

For AWS::EC2::Instance, we currently implement the Tags property, but incorrectly append the tags data to the instance metadata (which is only availably via the openstack-native nova metadata API). This does not align with AWS since they specify the Tags get appended to the EC2 tags, as described above by the reporter.

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-tags

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-tags.html

From:

http://aws.amazon.com/cloudformation/faqs/

"AWS CloudFormation automatically tags EBS volumes and EC2 instances with the name of the AWS CloudFormation stack they are part of."

Assigning this to the reporter as they indicated they may contribute this fix when their nova EC2 Tags patch is accepted.

[Steve Baker (steve-stevebaker)]

Hey Stephen, could you point me at the gerrit review for your implementation of the *Tags calls?

[Stephen Gran (sgran)]

Hi,

https://review.openstack.org/#/c/20376/

Sorry about the delay.

Cheers,

[Stephen Gran (sgran)]

Hi,

I've been asked to break the review into smaller chunks. Here is the bit just for the tags API:
https://review.openstack.org/#/c/20412/

Thanks

[Steven Hardy (shardy)]

Note as per my comment on https://review.openstack.org/#/c/20412/, we'll need support for manipulating tags via the nova openstack-native API (not just the EC2 API), as I don't think we want to start mixing calls to the native and EC2 nova APIs if at all possible (all calls currently go via the native API)

[Steven Hardy (shardy)]

The nova code is not getting merged for grizzly, so we need to bump this to havanna. Should probably raise a blueprint and close this bug invalid (since it's really a feature):

https://review.openstack.org/#/c/23256/
https://review.openstack.org/#/c/23258/

[Steven Hardy (shardy)]

Closing invalid - BP raised : https://blueprints.launchpad.net/heat/+spec/tags-support