ToscaParserFailed with alarm tests

[Nguyen Hai]

Recently, these tests are failed. This may due to ToscaParser issues.

Test Group/Test case
tacker.tests.unit.test_tosca_templates_under_samples.TestSamples:
+ test_list_samples
+ test_alarm_sample
tacker.tests.unit.vnfm.infra_drivers.openstack.test_openstack.TestOpenStack
+ test_create_tosca_alarm_respawn
+ test_create_tosca_with_alarm_monitoring_not_matched
+ test_create_tosca_alarm_scale

There is a change in tosca-parser that affects the monitoring policies:

https://github.com/openstack/tosca-parser/blob/12be9db589794ca1564ed5ef664e9585cee68afc/toscaparser/triggers.py#L21

Affected heat-translator tosca monitoring policies:

https://github.com/openstack/heat-translator/blob/59eda86b88fe327b0c15931ec3e2b7308690f301/translator/hot/tosca/tosca_policies_monitoring.py

[Trinh Nguyen (dangtrinhnt)]

This's caused by the parameters were replaced:

https://github.com/openstack/tosca-parser/blob/master/toscaparser/triggers.py#L25

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/568634

[Cong Phuoc Hoang (hoangphuoc)]

This issue happens because of https://review.openstack.org/#/c/522935 is merged. I am fixing this error, with some patches (https://review.openstack.org/#/c/523021 and https://review.openstack.org/#/c/524260)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Trinh Nguyen (<email address hidden>) on branch: master
Review: https://review.openstack.org/568634
Reason: Abandon in favor of https://review.openstack.org/#/c/524260

[Nguyen Hai (nguyentrihai93-deactivatedaccount)]

So we need to fix it soon, it seems critical

[Nguyen Hai (nguyentrihai93-deactivatedaccount)]

Phuoc takes care of this bug: https://review.openstack.org/#/c/524260/