Block storage examples are not in sync with latest spec

Bug #1474487 reported by Vahid Hashemian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Heat Translator
In Progress
Undecided
Vahid Hashemian

Bug Description

Due to recent changes to the spec block storage examples in heat-translator are out-of-date with respect to the latest spec document and a couple of examples (H.1.5.3 and H.1.6.3 in w06-rev06) are missing.

Changed in heat-translator:
assignee: nobody → Vahid Hashemian (vahidhashemian)
Changed in heat-translator:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat-translator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203264

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-translator (master)

Reviewed: https://review.openstack.org/202304
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=24ea2895b4fd0001a39cca50671b5aa78892ffdd
Submitter: Jenkins
Branch: master

commit 24ea2895b4fd0001a39cca50671b5aa78892ffdd
Author: Vahid Hashemian <email address hidden>
Date: Wed Jul 15 14:41:13 2015 -0700

    Fix translation of block storage

    Fix block storage translation when custom relationship templates
    are defined in the template. Also, create unit tests to verify
    the translations.

    Also, fix minor inconsistencies between the spec and the block
    storage templates.

    Also, fix minor issues in block storage attachment translation,
    including renaming of 'location' property to 'mountpoint' as
    supported by heat.

    Change-Id: Iecbe10c592edda28197d1ed30fa2af7174d7bf55
    Closes-Bug: #1474574
    Partial-Bug: #1474487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat-translator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/203940

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/204204

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-translator (master)

Reviewed: https://review.openstack.org/203866
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=bf831f6a8c35186dddebd499f890c5ef37b40306
Submitter: Jenkins
Branch: master

commit bf831f6a8c35186dddebd499f890c5ef37b40306
Author: Vahid Hashemian <email address hidden>
Date: Mon Jul 20 16:43:26 2015 -0700

    Update the first block storage example to the spec (1)

    Sync up the first block storage example with the latest spec
    except for the scalar-unit input type. Also, add a unit test
    for it and remove redundant block storage unit tests.

    Change-Id: I73c07398f284a962507ec97cc0d4ba2d65759056
    Partial-Bug: #1474487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/203264
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=7d88184b7e6f8c9b9690bade18c33bda4eecb33d
Submitter: Jenkins
Branch: master

commit 7d88184b7e6f8c9b9690bade18c33bda4eecb33d
Author: Vahid Hashemian <email address hidden>
Date: Fri Jul 17 15:29:37 2015 -0700

    Add missing storage examples from the spec

    Add block storage examples 2 and 3 from the tosca yaml spec:
      Block Storage 2: Using a custom AttachesTo Relationship Type
      Block Storage 3: Using a Relationship Template of type AttachesTo

    Until scalar-unit input type is supported use supported units and
    add unit tests for their translation.

    Also,
      - Fix a minor issue with volume attachment translation
      - Fix translating extended relationship property definition

    Change-Id: I3f4ff1345e4a2cd734639fd801ea0d0b305bd475
    Partial-Bug: #1474487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/204204
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=4c9ce32b5ba17fd2dd509009ecf279e108c3605f
Submitter: Jenkins
Branch: master

commit 4c9ce32b5ba17fd2dd509009ecf279e108c3605f
Author: Vahid Hashemian <email address hidden>
Date: Tue Jul 21 11:36:17 2015 -0700

    Update the 6th block storage example from the spec (1)

    Sync the example with the spec except for scalar-unit input type
    and add a unit test to replace the outdated unit test.

    Change-Id: Ie7ff866f6dbfb62bcc0fff03b3c88f906b82fe94
    Partial-Bug: #1474487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/203940
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=e487a06c16f0ad0400295eacf2399202d5ee34c6
Submitter: Jenkins
Branch: master

commit e487a06c16f0ad0400295eacf2399202d5ee34c6
Author: Vahid Hashemian <email address hidden>
Date: Mon Jul 20 23:27:00 2015 -0700

    Update the 4th and 5th block storage examples (1)

    Sync up the 4th and 5th block storage examples with the spec
    except for scalar-unit input type and extended relatioship
    definition.

    Change-Id: I7a6872213ad4663d383f5bc32097278d5a2bc910
    Partial-Bug: #1474487

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.