Unit test failing build randomly

[Sahdev Zala]

Lately, unit test is failing Jenkins. However, this happens randomly and with few recheck no bug build is fine. Also, it doesn't happen locally. Though this is annoying and counter-productive and seems like there can be a bug in the code - may be need to write the specific code differently. I had a chat on IRC with infra core and they said though it's passing build there is something that's striking randomly and fails build. Let's consider this a bug and try to fix it.

Error (which occurs randomly) snippet from log:
2014-10-17 18:22:13.026 | Traceback (most recent call last):
2014-10-17 18:22:13.026 | File "translator/toscalib/tests/test_toscatpl.py", line 187, in test_template_macro
2014-10-17 18:22:13.026 | template = ToscaTemplate(self.tosca_elk_tpl)
2014-10-17 18:22:13.027 | File "translator/toscalib/tosca_template.py", line 56, in __init__
2014-10-17 18:22:13.027 | self.graph = ToscaGraph(self.nodetemplates)
2014-10-17 18:22:13.027 | File "translator/toscalib/tpl_relationship_graph.py", line 19, in __init__
2014-10-17 18:22:13.027 | self._create()
2014-10-17 18:22:13.027 | File "translator/toscalib/tpl_relationship_graph.py", line 39, in _create
2014-10-17 18:22:13.027 | if node.relationship:
2014-10-17 18:22:13.098 | File "translator/toscalib/nodetemplate.py", line 44, in relationship
2014-10-17 18:22:13.098 | for rtype in self.type_definition.relationship.keys():
2014-10-17 18:22:13.098 | File "translator/toscalib/elements/nodetype.py", line 68, in relationship
2014-10-17 18:22:13.099 | relatednode = NodeType(node_type)
2014-10-17 18:22:13.099 | File "translator/toscalib/elements/nodetype.py", line 23, in __init__
2014-10-17 18:22:13.099 | super(NodeType, self).__init__(ntype, self.NODE_PREFIX, custom_def)
2014-10-17 18:22:13.099 | File "translator/toscalib/elements/statefulentitytype.py", line 39, in __init__
2014-10-17 18:22:13.099 | raise InvalidNodeTypeError(what=entitytype)
2014-10-17 18:22:13.099 | InvalidNodeTypeError: Node type "tosca.nodes.tosca.relationships.ConnectsTo" is not a valid type.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129491

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129491
Committed: https://git.openstack.org/cgit/stackforge/heat-translator/commit/?id=93f7ed74b1282e266f7c8857b1f074c551a2ce61
Submitter: Jenkins
Branch: master

commit 93f7ed74b1282e266f7c8857b1f074c551a2ce61
Author: spzala <email address hidden>
Date: Sun Oct 19 15:29:08 2014 -0700

    Check for tosca keyword in the TOSCA type

    Check for tosca keyword in the given tosca type to handle short type name.

    Change-Id: I398a5192809ba88d2c11bcb0657a03dd0e1f97f9
    Closes-Bug: #1382646