Relative path to run-os-net-config will fail for custom nic-configs saved in a different directory

[Ronelle Landy]

Since this change: https://github.com/openstack/tripleo-heat-templates/commit/2985cd9a3a04acfe069c063c65ebf487a1413388,

if a user has a custom environment set up and copies the standard nic-configs (example: network/config/bond-with-vlans/controller.yaml) to a local directory to customize them and then passes that local directory to the overcloud deploy command, the deployment will fail - being unable to find: ../../scripts/run-os-net-config.sh.

I discussed this briefly with dprince:

<dprince> rlandy: is your bond-with-vlans out of tree?
<rlandy> <dprince> rlandy: if so the path the the run-os-net-config.sh script needs to be fully qualified I think

Consequently, I added a review to the CI code to modify the templates (after they were copied) to use the full path to run-os-net-config.sh script.
The review was -1'ed - the objection of the CI team being that copying nic-configs to an local directory to modify them is a recognized workflow and the templates should be able to handle that.

Also, the relative path to run-os-net-config is not a parameter that could be easily overwritten in the network-environment.yaml.

[Dan Prince (dan-prince)]

Using the full path as you suggested doesn't sound like a bad option to me.

Alternately, for CI you could copy your custom-nics files into the t-h-t tree and use them with a custom environment file so that the relative path would work more nicely then. If you nics lived in the tripleo-heat-templates/network/configs/ directory all would work well.

I don't think besides these two approaches there is another option at this time. We could write a custom heat hook to drive the network configuration. This would live in the heat-agents project and avoid having to specify a hard coded path altogether. This is doable, and could make the release but it is sort of a new feature I think.

[Ronelle Landy (rlandy)]

I am ok with putting the custom nic-configs back into the tripleo-heat-templates/network/configs/ directory if that is the recommended practice.

For the sake of customers who may use custom nic-configs (which could be anyone with a non-standard hardware setup), I think this should be doc'ed somewhere.

Otherwise, having the relative path to run-os-net-config be a parameter that could be overwritten in the network-environment.yaml file would also work.