Salt config handler does not account for non-standard return codes

Bug #1483336 reported by Randall Burt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Heat Templates
Fix Committed
Medium
Randall Burt

Bug Description

Salt doesn't always return 0 on success. We need to check for task results in the event of a none-zero return code to see if the run really failed or not.

Changed in heat-templates:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Randall Burt (randall-burt)
no longer affects: heat
Changed in heat-templates:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-templates (master)

Reviewed: https://review.openstack.org/211254
Committed: https://git.openstack.org/cgit/openstack/heat-templates/commit/?id=10fd46579aeddf4a03a0d0d6354c96833125c93e
Submitter: Jenkins
Branch: master

commit 10fd46579aeddf4a03a0d0d6354c96833125c93e
Author: Randall Burt <email address hidden>
Date: Mon Aug 10 11:34:17 2015 -0500

    Handle non-zero success codes from Salt

    Salt does not always return 0 on success so verify actual
    task results on non-zero return codes. Also add test for
    salt config hook.

    Change-Id: Ib848ef27ae29417ca38874d8310bdcd2bc35e2c3
    Co-Authored-By: Chris Hultin <email address hidden>
    Closes-Bug: #1483336

Changed in heat-templates:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.