Implicit dependency between two SoftwareDeployment resources causes double run (rdo-icehouse-release)

[Jacques Uber]

Running the first attached template causes the file '/tmp/dupe' to have the contents:
here!
here!

(Thus, the app_config SoftwareConfig has been ran twice)

When you remove the implicit dependency the double run goes away (see second attached template).

Note that the only difference between the two templates is the very last line.

I am using an image built with dib that contains the following elements (not sure if relevant):
vm
heat-cfntools
heat-config-cfn-init
heat-config
heat-config-script
os-collect-config
os-refresh-config
os-apply-config
(a few other custom elements)

[Steve Baker (steve-stevebaker)]

Moving to heat-templates. I think 55-heat-config will need to persist and check a list of which config UUIDs have been executed so they are only executed once.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/140886
Committed: https://git.openstack.org/cgit/openstack/heat-templates/commit/?id=2b33ca539f2bade702c07e18d86220a8148fa29f
Submitter: Jenkins
Branch: master

commit 2b33ca539f2bade702c07e18d86220a8148fa29f
Author: Steve Baker <email address hidden>
Date: Thu Dec 11 11:02:15 2014 +1300

    Write each deployed config json to file

    Previously 55-heat-config assumed that executing a hook with some
    config is an idempotent operation, so it made no effort to prevent
    a hook being invoked with the same config multiple times. This means
    that whenever *any* deployment metadata changes *all* configs are
    run against their hooks again. This would be undesirable for
    non-idempotent configs, or configs which are expensive to execute.

    This change writes out the config json to files in
    /var/run/heat-config/deployed and uses the presence of this file to
    determine whether that config has been deployed already. This also
    improves the debugging experience as a single hook execution can be
    triggered manually by running:
      /var/lib/heat-config/hooks/<hook> < /var/run/heat-config/deployed/<cid>.json

    Closes-Bug: #1376008
    Closes-Bug: #1365302

    Change-Id: Id2d2f623508be3049a7db8a39f5444ccac9257d6