metering tagging fails in AutoScalingCeilometer.yaml

[Mike Spreitzer]

cfn/f17/AutoScalingCeilometer says

  WebServerGroup:
    Type: AWS::AutoScaling::AutoScalingGroup
    Properties:
      ...
      Tags:
      - {Key: metering.server_group, Value: WebServerGroup}

and

  CPUAlarmHigh:
    Type: OS::Ceilometer::Alarm
    Properties:
      ...
      matching_metadata: {'metadata.user_metadata.groupname': {Ref: 'WebServerGroup'}}
      ...

The members get tagged with the string literal "WebServerGroup". The relevant logic is in the _tags method of the InstanceGroup class in the heat/engine/resources/autoscaling.py file. It reads like this:

        for t in tags:
            if t[self.TAG_KEY].startswith('metering.'):
                # the user has added one, don't add another.
                return tags
        return tags + [{self.TAG_KEY: 'metering.groupname',
                        self.TAG_VALUE: self.FnGetRefId()}]

In the template at hand, that first return is used, and so the literal tag is returned. However, the alarm is looking for the ID of the group, not its stack-local name. The alarm fails to work properly due to this mismatch.

The template can be fixed by simply removing the Tags property from the ASG. In that case the last line of _tags is used, which tags the group's members with the group's ID, which is what the alarm looks for.

[Mike Spreitzer (mike-spreitzer)]

Bill Arnold has submitted a fix, I do not understand why it is not listed here.

https://review.openstack.org/#/c/82158/

[Tom Fifield (fifieldt)]

Mike,

As far as I can tell, the syntax in the commit message is correct, and the patch should have been noted here.

I'd get in touch with the infrastructure team at #openstack-infra on IRC, or by submitting a bug at https://bugs.launchpad.net/openstack-ci

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82158
Committed: https://git.openstack.org/cgit/openstack/heat-templates/commit/?id=454491d6da2e8c7156ff0b9cd6e857db58fcca27
Submitter: Jenkins
Branch: master

commit 454491d6da2e8c7156ff0b9cd6e857db58fcca27
Author: Bill Arnold <email address hidden>
Date: Fri Mar 21 14:07:57 2014 -0400

    Remove tag to allow default resolved group id

    Change-Id: I2ff271cc0c41fd7801e18cf6795d4fb9134adc18
    Closes-Bug: #1290980