heat-dashboard

Setting name API_TIMEOUT/API_PARALLEL is too generic

Bug #1750930 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
heat-dashboard
Fix Released
High
Kaz Shinohara

Bug Description

openstack-dashboard setting parameter names are global under django.conf.settings.
heat-dashboard has settings API_TIMEOUT and API_PARALLEL.
They should have a prefix like "HEAT_" or "HEAT_TEMPLATE_GENERATOR_" to indicate they are for heat_dashboard.

Kaz Shinohara (kazsh)
Changed in heat-dashboard:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Kaz Shinohara (kazsh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/547307

Changed in heat-dashboard:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-dashboard (master)

Reviewed: https://review.openstack.org/547307
Committed: https://git.openstack.org/cgit/openstack/heat-dashboard/commit/?id=7732884d372af7da03583823995a427ac79ca8d3
Submitter: Zuul
Branch: master

commit 7732884d372af7da03583823995a427ac79ca8d3
Author: kaz_shinohara <email address hidden>
Date: Fri Feb 23 16:25:32 2018 +0900

    Rename API_TIMEOUT and API_PARALLEL vars

    API_TIMEOUT and API_PARALLEL, both of them are for template generator
    and the naming looks too generic. This is not good because they will be
    global under django. It's better to rename them to indicate both
    parameters for heat-dashboard.

    Change-Id: I1ad610fd796d158174ae9cb855bd5d8da72bc1f8
    Closes-Bug: #1750930

Changed in heat-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat-dashboard 1.1.0

This issue was fixed in the openstack/heat-dashboard 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.