Intrepid regression: carriage-return required after finger scan
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HAL |
Confirmed
|
Medium
|
|||
thinkfinger (Ubuntu) |
Fix Released
|
Medium
|
Abhinavsaha | ||
Bug Description
0.3+r118-0ubuntu3
Was working prior to this version, but now requires carriage return both on login from gdm or for admin password via sudo or gksudo etc.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Patrick Hetu (patrick-hetu) wrote : | #1 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
echo6 (echo6-uk) wrote : | #2 |
Thanks for the response. I've recently had occasion to do a full install of 8.04 followed by the installation of thinkfinger and this bug has not appeared, atm I can not repeat it.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
rupa (rupa) wrote : | #3 |
confirming this recently began happening on my intrepid install.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #4 |
I can confirm this on Intrepid as well.
It seems to be related to libpam-
I don't see any errors in the pam debug output about sending the enter event. Either libpam-thinkfinger is misusing uinput somehow or GDM is not processing the key event (maybe it's blocking focus on the password prompt textbox?).
Regards,
Jon Oberheide
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #5 |
- thinkfinger-pam-uinput.patch Edit (553 bytes, text/plain)
After debugging for far too many hours, I have an apparent hack/fix.
Simply setting another KEYBIT along with our KEY_ENTER seems to fix the issue. The other KEYBIT can be any value and it doesn't seem to matter if the other KEYBIT is set before or after KEY_ENTER. If another KEYBIT is not set, it appears that the kernel is not sending the KEY_ENTER event.
I don't recommend committing this until we figure out what the root cause is, but if anyone else experiencing the problem could test it and verify that it resolves their issue, that'd be great.h
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #6 |
FYI, this issue of not receiving a key event when only one is set is reproducible in a standalone test program outside of thinkfinger-pam. So either it's a kernel issue or for some reason uinput wasn't designed to work with only a single KEYBIT set (which seems incorrect since it worked with earlier kernels).
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Patrick Hetu (patrick-hetu) wrote : | #7 |
I also notify that the bug doesn't happen when you are in a virtual terminal (ctrl-alt-f1) .
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #8 |
Ah, nice catch Patrick. Perhaps it is something in xorg/xinput/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #9 |
I can confirm that downgrading all my xorg packages to hardy fixes the problem.
I also can confirm this issue. The problem does not happen on the console (ctrl-alt-f1), but in X.
I had no problems before upgrading to Intrepid.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #11 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #12 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #13 |
I've attached two samples that show this behavior outside of thinkfinger.
They both create a uinput device and send a KEY_ENTER event. In bad.c, when the device is only set up with a KEY_ENTER key, the KEY_ENTER event is not observed in X. However, in good.c, if another supported key (say KEY_A) is added to the uinput device as well, the sending of the KEY_ENTER event works just fine.
Both of the testcases work as expected outside of X in the terminal which leads to me to believe something is getting munged in X's input layer.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Tom Jaeger (thjaeger) wrote : | #14 |
My guess is that the new input hotplugging magic selects the wrong driver for the uinput device.
If I add a section (this might already be there, not sure anymore)
Section "InputDevice"
Identifier "Generic Keyboard"
Driver "kbd"
Option "XkbRules" "xorg"
Option "XkbModel" "pc105"
Option "XkbLayout" "us"
EndSection
to my xorg.conf and then enable it by adding a line
InputDevice "Generic Keyboard"
to the "ServerLayout" section, the fingerprint reader works as before.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Raja (rajajs) wrote : | #15 |
That works great for me.
The InputDevice section was already there with the entry for the keyboard. But I had to add the line to the "ServerLayout" section. Once I restarted X, I could log in without following the swipe with a carriage return.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #16 |
- thinkfinger-uinput-hack.patch Edit (471 bytes, text/plain)
Attached is a patch to thinkfinger that should workaround the bug by adding a dummy key (KEY_A) to the uinput device.
It's certainly not a proper fix to why xorg is not correctly sending the KEY_ENTER but it's certainly an option for those of you who find hitting enter after you swipe annoying and/or don't have an xorg.conf to add the configuration workaround.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Roger Binns (ubuntu-rogerbinns) wrote : | #17 |
Tom's workaround worked for me. The keyboard input device and serverlayout reference were commented out claiming that HAL would deal with them after the upgrade. I uncommented and all works as before.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Shane Par-Due (shanepardue) wrote : | #18 |
I don't see a "ServerLayout" section" on Intrepid Ibex using Envy to handle my xorg.conf.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Khashayar Naderehvandi (khashayar) wrote : | #19 |
Perhaps this should be reported upstream at freedesktop's bug tracker?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Thomas Ibbotson (thomas-ibbotson) wrote : | #20 |
<quote>
to my xorg.conf and then enable it by adding a line
InputDevice "Generic Keyboard"
to the "ServerLayout" section, the fingerprint reader works as before.
</quote>
Adding this to my xorg.conf causes unwanted side-effects, such as causing my volume control button next to my headphone jack to stop working, and bizarrely stopping the key combinations ctrl-<arrow key> to stop working also. So this is not an option for me.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #21 |
Packages which resolve this issue are available in my PPA:
https:/
deb http://
deb-src http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Kasper Laursen (kasper-laursen-deactivatedaccount) wrote : | #22 |
You are the man Jon Oberheide!!
Everything work just fine now.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Philipp Dreimann (philipp-dreimann) wrote : | #23 |
will the fix be included in the main archive?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #24 |
Unsure. It uses the workaround patch previously posted (adding a dummy KEY_A key capability to the uinput device). Without the workaround, the uinput device doesn't even show up in "xinput list". For some reason, a keyboard uinput device with only a KEY_ENTER is not sufficient to be registered.
So while it's more of a workaround than a fix, it does indeed resolve the issue and has absolutely zero side effects.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #25 |
FWIW, neither Fedora 9 nor Fedora 10 (probably the more relevant of the two) exhibits the problem.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#26 |
When creating a uinput device with only one key, hal incorrectly assigns it as a "button" rather than a "keyboard". This problem manifests itself in libpam-thinkfinger when a uinput device is creating to automatically send a carriage-return after the user swipes his fingerprint.
The problem lies in input_test_key() in hal's hald/linux/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#27 |
Created an attachment (id=20043)
failed uinput testcase
bad.c creates a one-key keyboard with KEY_ENTER and attempts to send the KEY_ENTER event. since the device is not recognized as a keyboard, the KEY_ENTER is not processed.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#28 |
Created an attachment (id=20044)
workaround uinput testcase
bad.c creates a one-key keyboard with KEY_ENTER and attempts to send the KEY_ENTER event. by adding an extra dummy key (KEY_A), the uinput device is recognized as a keyboard and sends the KEY_ENTER event properly.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#29 |
(In reply to comment #2)
> Created an attachment (id=20044) [details]
> workaround uinput testcase
>
> bad.c creates a one-key keyboard with KEY_ENTER and attempts to send the
> KEY_ENTER event. by adding an extra dummy key (KEY_A), the uinput device is
> recognized as a keyboard and sends the KEY_ENTER event properly.
whoops, s/bad.c/good.c in that last comment.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Diogo Matsubara (matsubara) wrote : Re: following finger scan requires carriage-return | #30 |
I had the same problem. I installed the packages from Jon Oberheide's PPA and it worked. Thanks Jon.
Here's the lsusb output for my fingerprint reader:
Bus 001 Device 004: ID 0483:2016 SGS Thomson Microelectronics Fingerprint Reader
I'm on a Thinkpad X61.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #31 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #32 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #33 |
I've tracked down the source of this issue in hal's hald/linux/
In input_test_key(), hal will figure out the size of the bitmask of the devices (num_bits, aka the number of "buttons" this input device has). If num_bits == 1, hal will treat the device as a "button" (eg. power/sleep/
This explains exactly why having only a single key on the uinput device (KEY_ENTER) fails to work and adding a second dummy key (KEY_A) fixes the problem. Without the dummy key, the uinput device is treated as a "button" instead of a "keyboard" and does not send the KEY_ENTER event when using libpam-thinkfinger.
I'll email upstream and figure out if there's a proper fix to allow one-button keyboards or if hacking around it is the best approach.
Changed in hal: | |
status: | Unknown → Confirmed |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#34 |
Created an attachment (id=20094)
proposed patch
This patch implements what the inline TODO suggests and checks for a id/bustype of BUS_HOST instead of assuming that any 1-bit input devices are acpi buttons. The patch fixes the problem described in the bug as 1-bit key devices are now handled as "keyboards" instead of "buttons".
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
sachem_s (sachem-s) wrote : | #35 |
Recently upgraded from ubuntu 8.04 to 8.10 on my Dell XPS 1330, the finger print module worked perfectly before the upgrade, but now .....
firstly I had to hit carriage return after the swipe, but this was later fixed after I installed packages from Jon Oberheide.
But there's something else I realized now, if I try to type my password (instead of swiping my finger) then it prompts me to retype the password, and it does this thrice.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Marius Gedminas (mgedmin) wrote : | #36 |
sachem_s: please file a separate bug for your inability to log in by typing the password instead of swiping a finger.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #37 |
sachem_s: please check if in /etc/pam.
auth [success=1 default=ignore] pam_unix.so try_first_pass nullok_secure
otherwise that module won't use the password previously submitted to the thinkfinger module, and it will prompt you for another password.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Ghosty (ghosty.be) wrote : | #38 |
Thx Jon Oberheide, this works great! Also nice bug tracking and description.
I added this fix to the thinkwiki descriptions for T61p (see: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Marius Gedminas (mgedmin) wrote : | #39 |
Jon: I've libpam-thinkfinger 0.3+r118-
If I swipe my finger, no spurious Enter keystrokes appear.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #40 |
This regression still exists in Jaunty, too.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
mannheim (kronheim) wrote : | #41 |
Marius: The extra "Enter" keypress that you describe may not be due to the modified package 0.3+r118-
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
kaefert (kaefert) wrote : | #42 |
Thanks Jon Oberheide!
Your patch works perfectly for me.
The modifying of the xorg.conf did break my keyboard layout (keyup got interpreted as print key...)
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #43 |
I suspect, but have yet to test, that the extra <CR> defect was introduced in revision 116 of the upstream code:
http://
With Jon's fix in place, I suspect that we can revert that change.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #44 |
I have confirmed on my system by building Jon's PPA package from source that with Jon's PPA + reverting r116, I have fingerprint working properly and if I choose to type the password, I don't get the extra <cr>.
Jon, do you want to do that in your PPA for people to test? And let's start to get this pushed into Intrepid and Jaunty to fix the bug.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #45 |
The thinkfinger packages in my PPA are only a workaround for the underlying bug in hal. The upstream hal bug hasn't gotten much attention though.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #46 |
> The thinkfinger packages in my PPA are only a workaround for the underlying bug in hal.
> The upstream hal bug hasn't gotten much attention though.
Yes, I know. But in the meantime, while waiting for upstream to fix their issues, between your workaround and reverting that change I found, we can have a functioning package that delivers the expected behavior. I say let's go with it. The fixes are simple and maintainable.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Olek Wojnar (olekw) wrote : | #47 |
FWIW, _how_ we fix the bug will be transparent to the end user but not being able to use their fingerprint scanners is _VERY_ visible. It makes Ubuntu look bad, no matter where the actual fault lies for the problem. If it really is a simple workaround, my preference would be to document that and go with it until upstream gets around to fixing the hal bug. Just my two cents...
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #48 |
Jon, I have attached the patch to Bug 236344. I've tested this with both Intrepid and Jaunty, and we should be good to go with it. Would you mind doing the honors? :-) Do we somehow to have get the attention of Scott James Remnant (q.v., https:/
Quick link: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #49 |
thinkfinger-
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #50 |
They are up at https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #51 |
I installed from your PPA, and it is working fine for me, Jon. I think that we've got this fixed. :-)
What do we need to do to get this into Jaunty and either a backport or update for Intrepid? I suppose for Intrepid the first step would be -proposed.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Rooney (mrooney) wrote : | #52 |
Not sure why this isn't Confirmed, so I'll do so, as I can confirm it as well. Also thanks Jon, your PPA addressed the issue perfectly for me! I'd love to see this working out-of-the box on Jaunty.
Changed in thinkfinger: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #53 |
For those of us testing Jaunty, please see Bug 311732. And please confirm if you also see that problem.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #54 |
Jon,
I have subscribed Scott James Remnant, hoping that he can help us get this patch into MOTU, since he has been doing the thinkfinger packaging most recently.
According to what I understand from https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #55 |
- thinkfinger_0.3+r118-0ubuntu4~ppa2.diff Edit (1.1 KiB, text/plain)
Here's the composite patch of the key bit workaround and reverting r116.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
clw3388 (clw3388) wrote : | #56 |
Jon Oberheide's fix at https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Aleksey Kirpichnikov (alexcoder) wrote : | #57 |
After installing Jon Oberheide's packages i can't login to Gnome. After i swipe finger Gnome began to load and immediately crash then GDM reloading. If i enter my password by typing everything fine.
What information should i post here?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #58 |
Which version of Ubuntu? Is everything else updated? I'm not having any problems except with Jaunty's 2.6.28-4 kernel, which has numerous issues. I use the new packages with Intrepid and with Jaunty's 2.6.28-3 kernel.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Aleksey Kirpichnikov (alexcoder) wrote : | #59 |
Intrepid updated from 8.04.1
Dell xps m1330
2.6.27-11-generic
Output in syslog:
kernel: [ 8496.036565] input: Virtual ThinkFinger Keyboard as /devices/
t/input14
gdm[10886]: WARNING: gdm_slave_
In Xorg.0.log.old
Backtrace:
0: /usr/X11R6/
1: [0xb8020400]
2: /usr/X11R6/
3: /usr/X11R6/
4: /usr/X11R6/
5: /usr/X11R6/
6: /usr/X11R6/bin/X [0x8195668]
7: /usr/X11R6/
8: /usr/X11R6/
9: /lib/tls/
10: /usr/X11R6/bin/X [0x8071101]
Saw signal 11. Server aborting.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#60 |
Any progress on this bug? I haven't been able to use my fingerprint scanner for about 6 months now and this is getting very, very frustrating. Jon submitted a proposed patch several months ago so this should be a fairly painless fix. Thanks in advance!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #61 |
I've the same problem with Jaunty and kernel 2.6.28-11-generic.
The xorg.conf workaround worked for me on intrepid, but it does not work anymore.
I do not suffer for bug #311732, the fingerprint works, but I need to press the enter key.
Are the Jon packages available for Jaunty? Thanks.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #62 |
Vreixo,
I'll post some thinkfinger packages for Jaunty later today in my PPA.
Regards,
Jon Oberheide
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
bradleyd (bradleydsmith) wrote : | #63 |
Thanks Jon--having the same issue.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jon Oberheide (jon-oberheide-deactivatedaccount) wrote : | #64 |
The thinkfinger packages for jaunty are built and available in my PPA:
deb http://
deb-src http://
Let me know if there's any issues!
Regards,
Jon Oberheide
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #65 |
Thank you!
I will test them today evening.
Cheers,
Vreixo
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #66 |
Guys, as noted above, please see Bug 311732. This has been fixed in a PPA (https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #67 |
They work very well.
Thank you!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
eZoulou (florent-ezoulou) wrote : | #68 |
Works great for me too. Thanks!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
farchumbre (farchumbre) wrote : | #69 |
Dear Jon,
I am new to linux.
can you explain me how to install your packages?
thanks
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #70 |
farchumbre, you can follow the instructions here:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
farchumbre (farchumbre) wrote : | #71 |
thanks
now it works great, but there are two problems:
I am using multi keyboards english and french
and as soon as I use the thinkfinger for the first time the keyboards stop working correctly
the other thing is that i can't use thinkfinger to unlock the screen after the screensaver was activated
any ideas?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Launchpad Janitor (janitor) wrote : | #72 |
This bug was fixed in the package thinkfinger - 0.3+r118-0ubuntu4
---------------
thinkfinger (0.3+r118-0ubuntu4) karmic; urgency=low
[ Thomas Jaeger ]
* Fix breakage when running on 2.6.28 kernel (LP: #311732)
* Fix typo in README.Debian (LP: #243339)
[ Jon Oberheide ]
* Use a workaround to convince HAL to treat virtual thinkfinger device as a
keyboard (LP: #256429)
* Revert r116 to avoid extra CR being sent.
-- Thomas Jaeger <email address hidden> Mon, 23 Mar 2009 21:20:01 -0400
Changed in thinkfinger (Ubuntu): | |
status: | Confirmed → Fix Released |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
rupa (rupa) wrote : | #73 |
This behavior has reappeared in karmic sometime over the last couple of days.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #74 |
@rupa, not for me. What behavior are you seeing, and which version do you have installed?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
rupa (rupa) wrote : | #75 |
some more updates and reboots, and things are back to normal. Sorry for the noise.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
David Cava (dcavagar) wrote : | #76 |
I have the same problem in karmic before update my system with xorg-edgers PPA packages. I try the Jon Oberheide packages " thinkfinger - 0.3+r118-
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Raja (rajajs) wrote : | #77 |
I am working on a fresh 64-bit Karmic install being upgraded from beta onwards. The problem of carriage return being required after finger swipe has appeared over last couple of days - first time I am seeing it in karmic. My version of thinkfinger-tools is 0.3+r118-0ubuntu4. Anyone else seeing this ? and anything else I can do?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #78 |
No problem for me, it works out-of-the-box in a fresh 64bit karmic install. Note that I have not updated from beta, I have installed the final release.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Raja (rajajs) wrote : | #79 |
A reboot seems to have fixed the problem. Seems to have been a situation something like rupa. It appeared for some time, and seems to have got fixed with some updates.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#80 |
also reproducible on gentoo: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#81 |
I bisected myself through the xf86-input-evdev versions 2.2.5 to 2.3.1, checking whether my fingerprint reader would still be functioning without the necessity to append an extra Enter after the swipe.
The first bad commit was this one:
commit 1f641d75edba739
Author: Oliver McFadden <email address hidden>
Date: Thu Jul 23 13:19:49 2009 +0300
evdev: Only send the events at synchronization time.
Instead of just posting the button/key press/release events to the
server as soon as they arrive, add them to an internal queue and post
them once we receive an EV_SYN synchronization event.
The motion events are always sent first, followed by the queued events.
There will be one motion event and possibly many queued button/key
events posted every EV_SYN event.
Note that the size of the event queue (EVDEV_MAXQUEUE) is arbitrary and
you may change it. If we receive more events than the queue can handle,
those events are dropped and a warning message printed.
Tested on my Lenovo T400 using evdev for all input devices; keyboard,
touchpad, and trackpoint.
Signed-off-by: Peter Hutterer <email address hidden>
The versions before that commit send 3 events when swiping the finger over the reader:
Event. Dev: input11, Type: 1, Code: 28, Value: 1
Event. Dev: input11, Type: 1, Code: 28, Value: 0
Event. Dev: input11, Type: 0, Code: 0, Value: 1
whereas this version sends only 2 events:
Event. Dev: input12, Type: 1, Code: 28, Value: 1
Event. Dev: input12, Type: 1, Code: 28, Value: 0
the missing third event is only sent after Enter has been pressed on an external keyboard:
Event. Dev: input7, Type: 4, Code: 4, Value: 458792
Event. Dev: input7, Type: 1, Code: 28, Value: 1
Event. Dev: input7, Type: 0, Code: 0, Value: 0
Event. Dev: input12, Type: 0, Code: 0, Value: 1
Any idea what this commit has changed regarding the behavior of the fingerprint reader?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#82 |
Thanks to Jon's input, issue fixed by sending an extra sync event in pam_thinkfinger.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#83 |
(In reply to comment #8)
> Thanks to Jon's input, issue fixed by sending an extra sync event in
> pam_thinkfinger.
I guess it depended on the previous behavior which was to send events through as soon as we received them. This should be the correct solution. Sorry for any inconvenience caused; I didn't think to test fingerprint readers at the time.
Also the patch from comment #4 should go in (or at least via xorg-devel) if it hasn't already.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Pavel Rojtberg (rojtberg) wrote : | #84 |
this seems to have come back in lucid...
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
xak (zach-xak) wrote : | #85 |
Confirmed issue is back again on Lucid alpha3. Using package thinkfinger-tools 0.3+r118-0ubuntu4 on 64-bit Lucid alpha3 on Lenovo T61p.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Pelon (pelonicus) wrote : | #86 |
Confirmed issue is back again on Ubuntu 9.10, thinkfinger 0.3+r118-0ubuntu4 on 32-bit, in graphics mode.
In console(
KERNEL=
GNOME=2.28.1
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #87 |
I'm not sure to which bug report it was posted, but Ubuntu has decided to no longer support Thinkfinger. fprint is the supported direction, despite its flaws, because no one has been working on Thinkfinger upstream and RedHat is funding fprint development.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Björn Torkelsson (torkel) wrote : | #88 |
Checking the bug reports for the various fprint packages not much seems to be happening in Ubuntu and thinkfinger seems still to be the better option in most cases where the fingerprint reader is supported by thinkfinger.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #89 |
I'm having the same problem on Lucid, in graphics mode. It works ok in console.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Ben (ben-lemire) wrote : | #90 |
I'm also seeing this in Lucid. Everything seems to work, except I need to hit enter. This had been fixed in 9.10!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #91 |
I have switched to fprint (Noel, thanks for the hint), it works pretty well on my DELL Vostro 1710, fingerprint is (from lsusb):
0483:2016 SGS Thomson Microelectronics Fingerprint Reader
I have followed the instructions here: http://
Once configured, it prompts you to scan your finger, no chance for entering password instead... After several failed attempts, however, it falls back to password authentication. I wonder if there is any way to change such behavior.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Vreixo Formoso (metalpain2002) wrote : | #92 |
Update: I found an app fprint does not work pretty well with: gksu (see bug #347778),
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Samuel Piau (lostnet) wrote : | #93 |
- pam: send sync event after key events Edit (1.0 KiB, text/plain)
This patch seems to fix the problem in Lucid :
http://
I built the package with this patch and installed it.
Now I can use sudo in a gnome terminal without hitting the enter key.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Nate Moore (putermd) wrote : | #94 |
Looks like this bug is back in 10.04. Exact same symptoms.
I tried adding Jon's PPA, but there's no packages for Lucid.
Anyone got any ideas? I'm not really keen on the X hack, although I'm more comfortable with it than the patch Samuel Piau wrote about, primarily because I understand what the X hack is doing, not what his pam patch is doing.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Martin Schwenke (martin-meltin) wrote : | #95 |
The patch linked to in comment #83 works for me.
I'm trying to build a version for my PPA... but I just need to wait for various build messes to complete... I tried doing something useful with the package versions...
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Samuel Piau (lostnet) wrote : | #96 |
Here is a more detailed explanation about this patch, it is not related to pam, but to device input event processing.
At some point xf86-input-evdev was changed to a newer version (2.2.5 to 2.3.1 ?), and they changed the events processing :
evdev: Only send the events at synchronization time.
Instead of just posting the button/key press/release events to the
server as soon as they arrive, add them to an internal queue and post
them once we receive an EV_SYN synchronization event.
The motion events are always sent first, followed by the queued events.
There will be one motion event and possibly many queued button/key
events posted every EV_SYN event.
[...]
What happens is the additional key code that was added in previous thinkfinger patch is not sent until a real keystroke happens (when you press enter). The patch here adds a synchronisation event after the key code, so that it is immediately posted.
See the comments from Jon Oberheide and Philipp Gortan (mephinet) in this Gentoo Bug report :
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Nate Moore (putermd) wrote : | #97 |
I'm not at a level where I feel comfortable creating my own packages from source, which looks like something you did here. My previous attempts have failed spectacularly.
Are you in a position to share the package you built?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Ben (ben-lemire) wrote : | #98 |
So is the patch works, what's the next step to get it accepted? It would be nice if this regression didn't happen in future distribution updates.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Martin Schwenke (martin-meltin) wrote : | #99 |
Packages containing the patch are in my PPA at:
https:/
A quick test seems to show that these packages fix the problem. If others can install, test and confirm then perhaps someone will build an official package for lucid....
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Nate Moore (putermd) wrote : | #100 |
Thanks Martin. The packages work.
For some reason they wouldn't install using APT, so I downloaded them and used dpkg to install them.
APT always came back and told me I had the latest version.
I suspect it's because I used to have Jon's PPA and his version number is higher than yours, but that's just a theory.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Martin Schwenke (martin-meltin) wrote : | #101 |
Good to hear that it works for you too, Nate.
Yeah, the documentation has changed its recommendation for modifying package versions for PPAs, so I followed the new recommendation. Older packagers from PPAs (such as Jon's will probably look newer). You should be able to install mine by doing something like:
apt-get install libpam-
libthinkfin
thinkfinger
After that, if you remove the other PPA from your /etc/apt/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Bombenbach (bombenbach) wrote : | #102 |
I confirm that Martin's version works on my Thinkpad Z61m (SGS Thomson Microelectronics Fingerprint Reader) with Lucid.
The packages from Joe's repo, however, gave me
Warning: usb_bulk_read expected to read 0x40 (read 0x8 bytes).
when running "tf-tool --acquire" so that I couldn't use ThinkFinger at all.
ThinkFinger packages from Martin's repo work great, everything works as good as in Karmic and Jaunty.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
"Kosmonaut" Bernd Müller (bernado-tornado) wrote : | #103 |
I am confirming: Martin's version works fine here too.
(Got a SGS Thomson Microelectronics Fingerprint Reader).
Thanks!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Bombenbach (bombenbach) wrote : | #104 |
Since we already have a working fix for thinkfinger why would nobody add it to the official repo? For example for business users working fingerprint authentication may be an important criterion to use or not to use Ubuntu and since thinkfinger did work in Hardy, Jaunty and Karmic, for a lot of people doing dist-upgrade to Lucid this bug might become a really bad surprise!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Thomas (t-hartwig) wrote : | #105 |
This is still not fixed in Maverick. Is there any maintainer for this package?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Dimitri John Ledkov (xnox) wrote : | #106 |
Ubuntu review team, please fast-forward this bug into archive =)
tags: | added: patch |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Bombenbach (bombenbach) wrote : | #107 |
Before this bug will go into archive it should at least be f.i.x.e.d. I've even posted a message to the Ubuntu-motu maillist (http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Woonjas (woonjas) wrote : | #108 |
fix please?
pretty PLEASE?
this really was a nasty surprise when I upgrded from Karmic.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Ben (ben-lemire) wrote : | #109 |
Any word on when this is getting added to the repos? Someone, anyone?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Tom Jaeger (thjaeger) wrote : | #110 |
Changed in thinkfinger (Ubuntu): | |
status: | Fix Released → Confirmed |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Fabrice Coutadeur (fabricesp) wrote : | #111 |
Hi,
For your information, thinkfinger has been removed from Debian almost one year ago because it was dead upstream (http://
I'll upload the fix, but except if someone adopt it, this kind of problems will appear from time to time, with sometime no solutions. My advice is that you upgrade to fprint, as indicated in the Debian bug I referenced.
Fabrice
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Launchpad Janitor (janitor) wrote : | #112 |
This bug was fixed in the package thinkfinger - 0.3+r118-0ubuntu5
---------------
thinkfinger (0.3+r118-0ubuntu5) maverick; urgency=low
* pam/pam_
processed (LP: #256429). Patch taken from upstream bug tracker
(http://
-- Thomas Jaeger <email address hidden> Sat, 24 Jul 2010 10:19:07 +0200
Changed in thinkfinger (Ubuntu): | |
status: | Confirmed → Fix Released |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Tom Jaeger (thjaeger) wrote : Re: [Bug 256429] Re: Intrepid regression: carriage-return required after finger scan | #113 |
Thanks for uploading the package. fprint is just as dead upstream as
thinkfinger, and in addition does not allow the user to chose between
fingerprint and password authentication, so it's not a viable
alternative at this point.
On 07/27/2010 05:53 AM, Fabrice Coutadeur wrote:
> Hi,
>
> For your information, thinkfinger has been removed from Debian almost
> one year ago because it was dead upstream (http://
> bin/bugreport.cgi?bug=546005).
>
> I'll upload the fix, but except if someone adopt it, this kind of
> problems will appear from time to time, with sometime no solutions. My
> advice is that you upgrade to fprint, as indicated in the Debian bug I
> referenced.
>
> Fabrice
>
> ** Bug watch added: Debian Bug tracker #546005
> http://
>
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Noel J. Bergman (noeljb) wrote : | #114 |
If anyone is using thinkfinger with Maverick, please see Bug 609645. As noted there, I'm seeing the failure with the newly uploaded thinkfinger as well as current versions of fprint(d).
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Bombenbach (bombenbach) wrote : | #115 |
Excuse me, but why did you add it only to Maverick repos? What about Lucid?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Woonjas (woonjas) wrote : | #116 |
Indeed, are there any plans to fix in Lucid?
Changed in hal: | |
importance: | Unknown → Medium |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Martin Schwenke (martin-meltin) wrote : | #117 |
I took the suggestion and upgraded to fprint for a couple of months. It is a downgrade. pam_thinkfinger at least prompts sensibly when doing the gsudo-type things. pam_fprint just sits there stupidly and you have to guess when something is waiting for a fingerprint scan or password. Combine that with not being able to type the password while a scan is being requested and you have a pretty frustrating piece of software... :-(
Changed in hal: | |
importance: | Medium → Unknown |
Changed in hal: | |
importance: | Unknown → Medium |
Changed in thinkfinger (Ubuntu): | |
assignee: | nobody → Abhinavsaha (abhinavsaha) |
I confirm