ib_cursor_unlock() won't return error code when table isn't locked

Bug #582891 reported by Stewart Smith on 2010-05-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HailDB
Status tracked in Trunk
2.x
Low
Stewart Smith
Trunk
Low
Stewart Smith

Bug Description

=== modified file 'api/api0api.c'
this will fix it:

--- api/api0api.c 2010-05-19 15:25:58 +0000
+++ api/api0api.c 2010-05-19 15:26:25 +0000
@@ -5512,11 +5512,12 @@ ib_cursor_unlock(

  if (prebuilt->trx->client_n_tables_locked > 0) {
   --prebuilt->trx->client_n_tables_locked;
+ err= DB_SUCCESS;
  } else {
   err = DB_ERROR;
  }

- return(DB_SUCCESS);
+ return(err);
 }

Tags: api Edit Tag help
Stewart Smith (stewart) wrote :

this code appears to be unused...

Jay Pipes (jaypipes) wrote :

It is because of the enhancements for startStatement()/endStatement()

On Thu, 20 May 2010 14:28:20 -0000, Jay Pipes <email address hidden> wrote:
> It is because of the enhancements for startStatement()/endStatement()

possibly... something to think about/remove. It seems that in later
InnoDB versions it's gone.

--
Stewart Smith

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers