ib_cursor_unlock() is unused?

[Stewart Smith]

is the lock ever even incremented?

api/api0api.c
5513: if (prebuilt->trx->client_n_tables_locked > 0) {
5514: --prebuilt->trx->client_n_tables_locked;

include/trx0trx.h
565: ulint client_n_tables_locked;

row/row0sel.c
2946: (ulong) trx->client_n_tables_locked);
3066: if (trx->client_n_tables_locked == 0
3076: client_n_tables_locked == 0, because this might

trx/trx0trx.c
141: trx->client_n_tables_locked = 0;
273: || trx->client_n_tables_locked != 0) {
279: "InnoDB: and trx->client_n_tables_locked is %lu.\n",
281: (ulong)trx->client_n_tables_locked);
1690: || trx->client_n_tables_locked > 0) {
1694: (ulong) trx->client_n_tables_locked);

[Jay Pipes (jaypipes)]

This is no longer used in Drizzle because startTransaction() and startStatement()/endStatement() properly delimits statement boundaries. This code is used in MySQL to track when a statement starts and ends.

[Stewart Smith (stewart)]

On Wed, 19 May 2010 17:37:52 -0000, Jay Pipes <email address hidden> wrote:
> This is no longer used in Drizzle because startTransaction() and
> startStatement()/endStatement() properly delimits statement boundaries.
> This code is used in MySQL to track when a statement starts and ends.

I couldn't really find it in mysql innobase/innodb_plugin... so it's
probably well and truly dead.

--
Stewart Smith