Simpletest coverage at 89%

[XavierAntoviaque]

See attached.

[Vlad Dragu (vlad-dragu)]

I worked on the php unit tests and committed the code to launchpad.
On functions/func_general.php there are 3 functions that I had to mock.
Once mocked, I cannot get coverage for them. 2 of those functions return a random result (they calculate scan and hack chances based on a probability) and the other one does a header redirect location.
Can you please send me the coverage report for the functions/func_login.php file. It shows 100% on my system, I do not know why it shows 98 on yours.
Other than that, everything works.

[XavierAntoviaque (xavier-antoviaque)]

All good.

I'm keeping this one open to not forget to fix these during the next review with proppy, but the coverage is good enough to not block this release.

[Vlad Dragu (vlad-dragu)]

Currently is at 98%.

[Vlad Dragu (vlad-dragu)]

I raised the Simpletest coverage to 98% percent. Th remaining 2% percent is caused by:
 - mocked functions like hack/scan result
 - the classes added by the DataObject library which i should exclude from make check but i'm not really sure how to do it (they are all at 75%)
 - a function in site_collection class that returns a result based on the number of sites a user owns. In order to test it i must insert in the db 10000 sites. I wrote the test function that does that and performs the tests, but i commented it out because it takes a long time to execute

[david blanchard (david-blanchard)]

I just tried on my side - I've got indeed the 98%. Xav' are you ok with Vlad's explanation for the 2% and should we close the bug ?

[XavierAntoviaque (xavier-antoviaque)]

Yes, that's fine for this release.

But rather than closing it, I would target it toward the next release. We have been talking about discussing those with Proppy to cover the the remaining percents (and I'd like to have a look at the test for site_collection).