hacking H306 from-style

Bug #2019218 reported by zoumingzhe
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Won't Fix

Bug Description

This bug tracker is for errors with the documentation, use the following as a template and remove or add fields as you see fit. Convert [ ] into [x] to check boxes:

- [ ] This doc is inaccurate in this way: ______
- [ ] This is a doc addition request.
- [ ] I have a fix to the document that I can paste below including example: input and output.

If you have a troubleshooting or support issue, use the following resources:

 - The mailing list: https://lists.openstack.org
 - IRC: 'openstack' channel on OFTC

isort to sort from-style imports alphabetically, such as:
from a import c
from a.b import d

run flake8 will report: "H306: imports not in alphabetical order (a.c, a.b.d)"

Release: on 2018-06-28 14:25:50
SHA: e8a3a7eb967891d6874cfdc25dcea826dbf9bfd4
Source: https://opendev.org/openstack/project-team-guide/src/doc/source/bugs.rst
URL: https://docs.openstack.org/project-team-guide/bugs.html

Tags: ptg
Changed in openstack-manuals:
status: New → Invalid
Changed in openstack-manuals:
assignee: nobody → zoumingzhe (mingzhebaosheng)
affects: openstack-manuals → hacking
description: updated
description: updated
Changed in hacking:
status: Invalid → In Progress
Revision history for this message
zoumingzhe (mingzhebaosheng) wrote :

H306 seems to convert from-style to straight-style

Revision history for this message
Ghanshyam Mann (ghanshyammann) wrote :

we have a few feedback on the change proposed in gerrit https://review.opendev.org/c/openstack/hacking/+/882990

I do not think we can or should do this change as it is a almost changing in all the OpenStack projects and not finding what value it will add.

Instead of invalid we should mark it as 'Won't Fix'

Changed in hacking:
status: In Progress → Won't Fix
Revision history for this message
melanie witt (melwitt) wrote (last edit ):

Aside from the fact that this would require a very large number of changes in all projects, I don't see how the existing behavior is incorrect.

That is, the example given in comment 0:

from a import c
from a.b import d

is correctly identified as not in alphabetical order because each import does indeed represent the modules a.c and a.b.d respectively.

IMHO this bug is Invalid and I don't know the reasoning behind why https://isort.readthedocs.io considers the above example to be correct alphabetical ordering of module imports.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.