“Quit” does not work

[Stig Berggren]

This applies when waking up from hibernation. The stream does not update. When trying to quit the application with Ctrl + Q or selecting [Gwibber → Quit] nothing happens. Pressing the X button on the panel works, but the process remanins in the system monitor. Starting Gwibber again afterwards, there are no problems.

[Lmedinas-opensuse (lmedinas-opensuse)]

User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100723 SUSE/3.6.8-0.1.1 Firefox/3.6.8

Using gwibber from GNOME:Apps (2.31.91) the application doesn't quit.
This bug was also reported on launchpad https://bugs.launchpad.net/gwibber/+bug/603598/

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

[Luis Medinas (lmedinas)]

This happens because this part of code isn't right:

def on_window_close(self, *args):
    if self.model.settings["minimize_to_tray"]:
      self.on_toggle_window_visibility(self)
      return True
    else:
      self.save_window_settings()
      log.logger.info("Gwibber Client closed")
      gtk.main_quit()

  def on_quit(self, *args):
    self.service.Quit()
    log.logger.info("Gwibber Client quit")
    self.on_window_close()

so if "minimize to tray" option is not selected gwibber quit's fine.
If this option is selected gwibber won't quit as you can see in the code.

[Lmedinas-opensuse (lmedinas-opensuse)]

See my comments on the bug to see what's causing this problem.

[Luis Medinas (lmedinas)]

Proposed fix. With this simple fix gwibber behaves correctly.

[Lmedinas-opensuse (lmedinas-opensuse)]

Created an attachment (id=388062)
patch to fix this issue

[Lmedinas-opensuse (lmedinas-opensuse)]

James, this patch was attached on upstream LP if you want me to add it to our package and SR to G:A feel free to comment.

[James Ogley (riggwelter)]

Have applied this patch to the openSUSE packages - it works. Luis, do you want to create a branch to be merged for this or shall I?

[James Ogley (riggwelter)]

It's SR 48080 - also applied in home:Riggwelter:GNOME.

[Luis Medinas (lmedinas)]

I will create a branch to be merged.

[Ken VanDine (ken-vandine)]

I committed a modified version to trunk, you need to add a call to self.save_window_settings() before quitting.