The reply function is duplicated

Bug #529759 reported by Guillaume Pascal on 2010-03-01
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gwibber
Medium
Unassigned
gwibber (Ubuntu)
Low
Unassigned

Bug Description

The reply function is at once with the icon of the envelope and also in gear

Omer Akram (om26er) wrote :

Yes when there is a reply button then reply should not be in the gear icon.

Changed in gwibber:
status: New → Confirmed
Changed in gwibber:
status: Confirmed → Triaged
importance: Undecided → Medium
Changed in gwibber (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
tags: added: bitesize ui

Removing facebook from the title as this is a problem with all types of accounts

summary: - [Facebook] The reply function is duplicated
+ The reply function is duplicated
johnhamelink (johnhamelink) wrote :

Hey there, I found this bug through openhatch - thought I'd fix it. I'm new to OSS in general, but its about time I make a contribution.

papukaija (papukaija) on 2010-06-04
tags: added: patch
David Futcher (bobbo) on 2010-06-07
tags: added: patch-forwarded-upstream
Asheesh Laroia (paulproteus) wrote :

Here's the last update I'm aware of on the bug. Ryan, if you want to add a fresh comment, by all means do so.

A week ago, Ryan Paul said this much on IRC:

<segphault> no, I'm not really receptive to merging that
<segphault> the menu is supposed to be comprehensive. The overlap isn't redundancy, it makes sense
<segphault> it would be like saying that we should remove from the menu anything that has an equivalent feature in the toolbar
<segphault> the patch itself doesn't even work as advertised, because it doesn't take into account whether the user's gwibber theme is displaying the reply icon

Greg asked Ryan to update the bug with this information, since the patch submitter wasn't on IRC at the time.

<greg-g> segphault: mind adding that commentary to the bug?
<greg-g> segphault: just so people aren't left hanging
<segphault> greg-g: yeah, I'm going to do post a comment on there tomorrow when I'm less cranky
<greg-g> :)
<greg-g> no problem

Ryan, feel free to take it from here. I thought your original note wasn't too cranky, so I just posted it here.

Omer Akram (om26er) on 2010-07-19
Changed in gwibber (Ubuntu):
importance: Medium → Low
papukaija (papukaija) on 2011-06-11
tags: removed: patch
Bilal Shahid (s9iper1) wrote :

Thanks for your patch, unfortunately our busy developers haven't been able to review your patch in a timely manor. The gwibber codebase has seen significant change and it is likely this patch no longer applies. Please review it again and if it is still applicable, update it to work with the latest gwibber trunk. We will be doing a patch review day in the next few weeks and would like to review your patch. Thanks again for your contribution!

tags: added: patch-day-old
Changed in gwibber:
status: Triaged → Incomplete
Changed in gwibber (Ubuntu):
status: Triaged → Incomplete

Given the developer perspective provided by Asheesh, it seems this should be a "Won't Fix"...

David Klasinc (bigwhale) wrote :

Hi, this bug has been reported for the old version of the client and it is not valid anymore.

Changed in gwibber (Ubuntu):
status: Incomplete → Invalid
Changed in gwibber:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers