[wishlist] Support for Remember the last open size

Bug #421688 reported by picobird
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Gwibber
Fix Released
Wishlist
Ken VanDine

Bug Description

Could u set it remember the last open size,not to open a large window every time,especially Gwibber 2.0.

Tags: wishlist
picobird (picobird)
tags: added: wishlist
Revision history for this message
habtool (clive-wagenaar) wrote :

I agree with this idea
It also does not remember the size of the test input area (editor)

(This is on karmic kubuntu with gwibber 2.0.0)

Revision history for this message
Nizar Kerkeni (nizarus) wrote :

the bug concerning size is reported here in bug 422525

Revision history for this message
Sandy Armstrong (sanfordarmstrong) wrote :

Fixes in this patch:
* Remember previous window size and position (Bug #422525) when starting Gwibber (it was already remembered on quit, no it's also remembered on window close)
* Remember previous account tree splitter position
* Remember previous input area size
* Do not change input area height when resizing main window (Bug #422532)
* Add ability to save and restore integer list preferences (but only integer lists...other lists would not be supported with this approach)

Wanted to fix but didn't get to:
* Actual text space in input area should not shrink when in reply mode (when that little toolbar thing appears in the input area) (Bug #422532)
* Remembering selected stream (Bug #422525)

Problems with this patch:
* Every time I start gwibber, the input area gets smaller. Clearly I'm doing something wrong here.

Revision history for this message
Sandy Armstrong (sanfordarmstrong) wrote :

With Ken Vandine's help, figured out the problem with input area getting smaller (delay setting that splitter position by putting it in an idle_add call). He's got the updated patch in a branch.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

merged into lp:gwibber, thanks for the patch!

Changed in gwibber:
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → Wishlist
status: New → Fix Committed
Revision history for this message
Sandy Armstrong (sanfordarmstrong) wrote :

Sizes below a certain threshold are not properly saved even with this patch. This may be dependent on any number of thigs, I have not checked yet...but for me the width will always be restored to at least 398, and the height will always be restored to at least 334.

Changed in gwibber:
status: Fix Committed → Fix Released
Revision history for this message
J. Austin Rodriguez (jeanaustinr) wrote :

How do you apply the fix?

Revision history for this message
J. Austin Rodriguez (jeanaustinr) wrote :

Tried doing this in the Terminal:
   sudo patch p1 < size-and-position-fixes.patch

and it showed

patching file client.py
Reversed (or previously applied) patch detected! Assume -R? [n] y
Hunk #1 succeeded at 73 (offset 1 line).
Hunk #2 FAILED at 138.
Hunk #3 FAILED at 167.
Hunk #4 FAILED at 192.
Hunk #5 FAILED at 254.
Hunk #6 succeeded at 306 (offset 10 lines).
Hunk #7 FAILED at 909.
5 out of 7 hunks FAILED -- saving rejects to file client.py.rej
patching file config.py

What's the matter?

Revision history for this message
Sandy Armstrong (sanfordarmstrong) wrote :

The fix was already applied back in October.

Revision history for this message
Sandy Armstrong (sanfordarmstrong) wrote :

(Actually September)

Revision history for this message
J. Austin Rodriguez (jeanaustinr) wrote :

I'm using Gwibber 2.0.0, applied the patch but it still the same. What could possibly the problem?

Revision history for this message
Todd Bradshaw (snooptodd) wrote :

You need to close the app to have the window position saved. If the app is closed by logout it dosent save.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.