0 point on a intersect of two perpendicular lines

[Daniele Napolitano]

When clearing two perpendicular lines of gems which intersect at the moved gem, one line gives wrongly 0 points.

[AbuMaia (scarabdrowner)]

Here is a screenshot of when this occurs. The white gems in the middle-right of the screen, if the white gem is swapped horizontally with the purple gem to complete the two intersecting lines, one line gives the regular points for the level, but the other line gives 0 points.

http://dl.dropbox.com/u/8725574/Screenshot%20at%202012-02-04%2021%3A47%3A48.png

[AbuMaia (scarabdrowner)]

Update: If one of the intersecting lines will be a 4-gem line after the move, then both the 4-gem line and the 3-gem line will give the same number of points (I witnessed 20 points for each line on level 2).

[AbuMaia (scarabdrowner)]

Another screenshot. Orange gems, bottom right. I swapped the orange and yellow gems to complete the yellow line and the two intersecting orange lines, with one orange line having 4 gems. All three lines gave 10 points.

http://dl.dropbox.com/u/8725574/Screenshot%20at%202012-02-05%2018%3A41%3A46.png

[Simon Reed (xubuntu-o)]

The screenshot links no longer work, however I can confirm this behaviour of 0 points for the second intersecting line of 3.

[Daniele Napolitano (dnax88)]

I'm going to address the issue. The problem is that the game removes the first vertical alignment, then found a horizontal one of 2 gems, so no scores. I don't know how that it's handled in KDiamond or Bejeweled, how do you think should happen?

I'm going to give two points (es. 10 and 10 in the first level) for the two alignments, vertical and horizontal ones.

[Simon Reed (xubuntu-o)]

I conducted a thorough and detailed user survey (i.e. asked my wife) and the response was "I expect to get the points for both lines" so the points for two lots of 3 gems. However, the user panel (still my wife) queried the case of there being more than 3 gems: "What if one is a line of four?". So I believe the answer is:
"I should get as many points as I deserve".
So it should work out the horizontal and vertical points, display the points animation for both lines, then remove all the gems involved in those vertical and horizontal lines.

[Daniele Napolitano (dnax88)]

Fixed: https://git.launchpad.net/gweled/commit/?id=050d73d98d2dd29b7ad1acaf240da95a2dd844c1