Various visual glitches

[Matthew Paul Thomas]

I do not use gufw, but based on the screenshot in <http://img126.imageshack.us/img126/7526/screenshot1i.png>, it has a few visual design glitches.

* All the buttons do not have enough padding: they should have "12 pixels of padding to either side of centered text" <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-label-position>.

* Grouped buttons, e.g. "Add" and "Remove", should be the same width: "If appearing in a group of buttons, longest button label sets button size" <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-label-position>.

* The "Incoming" and "Outgoing" menu labels should end with colons, i.e. "Incoming:" and "Outgoing:". This is not specified in the HIG explicitly, but is shown in all the examples in <http://library.gnome.org/devel/hig-book/stable/controls-option-menus.html.en>.

* The "Rules" listbox should have a border to make it look inset. Compare the screenshots in <http://library.gnome.org/devel/hig-book/stable/controls-trees.html.en>.

* ( Remove ) ( Add ) should be ( Add… ) ( Remove ), like it is in other programs that have that pair of buttons.

* The resize grippy for a window should be in the corner of the window.

* The "Add new rule" dialog should instead be "Add Rule". <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-capitalization>

* In the same dialog, ( Close ) ( Add ) should be ( Cancel ) (( Add )).

It may help to split this bug report into eight bug reports that can be tracked separately.

[costales (costales)]

Thanks very much Matthew by your time and experience! ;)

I will fix all these bugs today :)

About the last bug: "In the same dialog, ( Close ) ( Add ) should be ( Cancel ) (( Add )).", I have doubts.
( Close ) Close the Add Window, not "Cancel" the add operation. The Add window is always visible until you "close" that window or the application.

"It may help to split this bug report into eight bug reports that can be tracked separately.". No, it's perfect.

Thanks again :) Best regards.

[Matthew Paul Thomas (mpt)]

You're welcome.

If the "Add" button in the "Add Rule" window does not close the window, then I don't understand how that window works at all. I have tried it in gufw 9.10.3, but the "Add" button is always insensitive, and I don't understand why. What is the button supposed to do there?

[costales (costales)]

Hi Matthew! :)

Well, I fixed all bugs for the version 10.04.1 (Ubuntu 10.04).

Could you do a quick review of the interface, please? Maybe exist others bugs.
For it, I recorded a video: http://www.youtube.com/watch?v=p4LzhlV_-cM

And I did a screenshots too (you can see all windows in Gufw):
http://img106.imageshack.us/img106/9136/screenshot1zn.png
http://img158.imageshack.us/img158/394/screenshotfr.png

In the video you can see the function of "Add" button.

Thanks VERY much!! :D

[costales (costales)]

About "Add" button in the "Add Rule" window:
"Add Rule" window isn't a modal window. It will visible always (if you click "Add..." in main window), and you can change the properties in main window simultaneusly.
It's as Gimp mode, you have 2 windows simultaneusly.
But you can close the "Add Rule" window if you push the "Close" button in "Add Rule" window.

In other way, if you need/like run the last version of Gufw, you can exec in terminal:
bzr branch lp:gui-ufw/gufw-10.04
cd gufw-10.04
sudo python gufw --dev

You can add or change the firewall as if Gufw will be installed.
When you finished, remove the gufw-10.04 directory ;)

Thanks and best regards!

[Matthew Paul Thomas (mpt)]

That looks much better. Unfortunately I don't have time for a proper review now, but I have one suggestion. Look at the interface for adding recipients when composing a message in Thunderbird. Notice how you don't need to open a separate window to add a recipient. You could use a similar approach to eliminate the "Add Rule" window altogether: instead of configuring a new rule in a separate window, configure it inside a new row in the "Rules" list.

[costales (costales)]

Thanks Matthew :)
No, I can't component the rule inside a new row in the "Rules" list, because a rule has more parameters, but a final rule only use a little space in "Rules" list. I think that a new windows it's a good idea.
Best regards.