make all main actions available in the menu

[Jeff Fortin Tam]

The main window's actions to add a new rule or remove a rule should be available in the Edit menu, as per HIG. It would also give a better reason for the existence of that menu.

[costales (costales)]

Hi!
What is "HIG"? :$
Thanks ;)

[Jeff Fortin Tam (kiddo)]

HIG is the acronym for (GNOME's) Human Interface Guidelines, sorry for not clarifying that sooner :) you can see them there, a very interesting read: http://library.gnome.org/devel/hig-book/stable/

In this specific case, the relevant section is http://library.gnome.org/devel/hig-book/stable/toolbars-appearance.html.en : "All functions that appear on your toolbars must also accessible via the main menu bar, either directly (i.e. an equivalent menu item) or indirectly (e.g. in the Options ▸ Settings dialog)."

[costales (costales)]

Hi! Uhh... It isn't a toolbar :O Only 2 buttons, and are more descriptibles the 2 buttons *-)
I see the same functionally in the menu redundant :O
More opinions please? ;)
Thanks!

[Emilio (turl)]

Marcos, I think you should add them. Having them in the edit menu makes sense to me, also, it gives the menu a reason to still be there (now it just has 1 button heh :P)

[costales (costales)]

Hi!
"Remove" is an action, not a window. I don't understand a entry in the menu for this.
"Add" is open a window... But...
Edit/Add Rules...
Edit/Preferences
Is this consistent???
I think not ;) I don't remember see it :O

[costales (costales)]

Hi! ;)
I don't see the integrated menu "Add" in the main menu :( I think the Edit menu isn't the place.
Sorry but I will not implemented this bug.
In other way, thanks very much for all your improvements!!! ;D

[Jeff Fortin Tam (kiddo)]

Hi, sorry for taking so long to actually reply to this bug report (it's been sitting in my inbox for months!). I am reopening because from what I understand of your last 2 comments, you may have misunderstood.

Actually: yes, "Add..." *, "Remove" and "Preferences" make sense in an Edit menu! Other apps (Gnumeric, Evolution, Epiphany, etc.) all have the "Preferences" in the Edit menu, apps such as Specto, Inkscape,

*: note that the "..." at the end of "Add..." is a design standard of menus, to indicate that clicking this option "requires further interaction" (meaning that it shows an "additional dialog", such as the "Add rule" dialog you already have).

More info about File and Edit menus:
http://library.gnome.org/devel/hig-book/stable/menus-standard.html.en

But then at the same time, I agree it's not a clear-cut and "easy" design problem to solve. I mean, the concept of a "File" menu when most applications don't even deal with actual files, is quite hotly debated too :)

[costales (costales)]

I'm thinking about this...

Which main menu will be better?
Edit > Add... / Remove
Preferences > Add... / Remove
Edit > Remove & View > Add...
Edit > Remove & Insert > Add...

I think the first :O What do you think? :)
Thanks very much!

[Jeff Fortin Tam (kiddo)]

Yes, the first one is better, if you mean that you have two separate
menu items, like this:

Edit > Add...
Edit > Remove

[costales (costales)]

I will do this menu in Edit:
    Add..
    Remove
    <Separator menu>
    Preferences
:)

[costales (costales)]

Uhm...
maybe must be this?
    Add Rule..
    Remove Rule
    <Separator menu>
    Preferences

[Jeff Fortin Tam (kiddo)]

2010/3/17 Marcos:

> I will do this menu in Edit:
> Add..
> Remove
> <Separator menu>
> Preferences
>

Yes, this is OK.

[costales (costales)]

But Add / Remove "what"?
I think Add Rule... and Remove Rule is more descriptive :O
What do you think?

[Jeff Fortin Tam (kiddo)]

Yeah, "Add rule..." and "Remove rule" make sense.

[costales (costales)]

This will fixed for Ubuntu 10.04 ;)
Thanks for your idea & time Jean! :D