Comply with ubuntu suggestions

Bug #261925 reported by Vadim Peretokin
2
Affects Status Importance Assigned to Milestone
Gufw
Fix Released
Medium
costales

Bug Description

Gufw was packaged an uploaded to REVU (http://revu.ubuntuwire.com/details.py?package=gui-ufw) and someone left comments, here they are. We should look at them and comply since they seem reasonable and the person knows more about it than us.

"debian/control:
- Package ufw is in section "admin", so gui-ufw should be there, too.
- "a GUI (Graphic User Interface) for ufw (Uncomplicated FireWall)" -> "graphical user interface for ufw" is enough (the same is valid for the manpage)
- "ports port(s)" in the long description
- I’d remove the "gufw is powered by ufw." (the short description already says that it’s an interface for it)
- I’d call the binary package "ufw-gtk" instead of "gufw", to make it more discoverable and so that it’s more obvious what it is.

debian/rules:
- Install file "gufw-launcher" in the install target, not binary-install.

debian/copyright:
- You say that the images are under "Creative Commons", but not which of the Creative Commons licenses.

debian/gufw.desktop:
- "gufw Firewall Configuration" -> "Firewall configuration" or even something like "Configure a firewall"
- The comment should start with a verb (and start with an upper-case character) and briefly explain what the application does, not what it is.
- Both System and Settings are primary categories, so it should only be in one of them. As it requires sudo privilegies, I’d say System is more appropriate."

Revision history for this message
costales (costales) wrote :

For new version:

[done] Package ufw is in section "admin", so gui-ufw should be there, too.

[done] "a GUI (Graphic User Interface) for ufw (Uncomplicated FireWall)" -> "graphical user interface for ufw" is enough (the same is valid for the manpage)

[Not apply to trunk] "ports port(s)" in the long description

[done] I’d remove the "gufw is powered by ufw." (the short description already says that it’s an interface for it)

[Not apply to trunk] I’d call the binary package "ufw-gtk" instead of "gufw", to make it more discoverable and so that it’s more obvious what it is.

[Not apply to trunk] Install file "gufw-launcher" in the install target, not binary-install.

[done] You say that the images are under "Creative Commons", but not which of the Creative Commons licenses.

[done] "gufw Firewall Configuration" -> "Firewall configuration" or even something like "Configure a firewall"

[done] The comment should start with a verb (and start with an upper-case character) and briefly explain what the application does, not what it is.

[done] Both System and Settings are primary categories, so it should only be in one of them. As it requires sudo privilegies, I’d say System is more appropriate."

Best regards.

Changed in gui-ufw:
assignee: nobody → marquinos
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

The reported things was suggestions for my package (that I think is different from yours).

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

s/was/were/

costales (costales)
Changed in gui-ufw:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.