'Paste your current local IP' is adding a trailing space

[Jeffrey Tratt]

The quick paste button adds the current IP, but when you try to add the new rule (Advanced Tab) it gives: "Error: No rules added. Review the log" on the bottom of the rules pane.

The Log reads:
"Error running: /usr/sbin/ufw allow in from 192.168.1.111 to 192.168.1.222 > ERROR: Bad destination address." If modifying the rule, it disappears.

when clicking the paste button '192.168.1.111 ' is added. Manually deleting the trailing space made it work.

Fresh install of Mint 19.1 Tessa with all updates as of 2019/04/29. I purged and reinstalled gufw with no success before noticing the trailing space.

Current build: Gufw Firewall 18.04.0 © 2008-2015 The Gufw Project

Thank you,
Jeff

[costales (costales)]

Thanks a lot Jeffrey!
This will be fixed in next release 19.10.
A hug.

[Jeffrey Tratt (jctratt)]

Thank you. I'm glad I could help. Not sure if it would be relevant, but it
might be helpful to also change the "From:" and "To:" labels to "Host:" and
"Client:" because in English swapping them is valid for either (at least in
my mind): From the Host to the Client or From the Client to the Host? I
usually just go find another rule I've got working and copy it ;) Not a big
deal, but since you'll have the hood open, it might be a quick fix, lol.
Thanks again. All the best!

On Wed, May 1, 2019 at 4:05 AM costales <email address hidden> wrote:

> Thanks a lot Jeffrey!
> This will be fixed in next release 19.10.
> A hug.
>
> ** Changed in: gui-ufw
> Status: New => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1826955
>
> Title:
> 'Paste your current local IP' is adding a trailing space
>
> Status in Gufw:
> Fix Committed
>
> Bug description:
> The quick paste button adds the current IP, but when you try to add
> the new rule (Advanced Tab) it gives: "Error: No rules added. Review
> the log" on the bottom of the rules pane.
>
> The Log reads:
> "Error running: /usr/sbin/ufw allow in from 192.168.1.111 to
> 192.168.1.222 > ERROR: Bad destination address." If modifying the rule, it
> disappears.
>
> when clicking the paste button '192.168.1.111 ' is added. Manually
> deleting the trailing space made it work.
>
> Fresh install of Mint 19.1 Tessa with all updates as of 2019/04/29. I
> purged and reinstalled gufw with no success before noticing the
> trailing space.
>
> Current build: Gufw Firewall 18.04.0 © 2008-2015 The Gufw Project
>
> Thank you,
> Jeff
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gui-ufw/+bug/1826955/+subscriptions
>

[costales (costales)]

Hi Jeffrey for the idea, but Gufw is an UI for ufw, then I'm keeping the
'keys' of ufw in Gufw.
ufw Is using from and to for everything, then I'll keep them :)
from ADDRESS [port PORT] [to ADDRESS [port PORT]
A hug!

[Jeffrey Tratt (jctratt)]

I see; that makes sense. Thank you for your work on this.

On Wed, May 1, 2019 at 4:25 PM costales <email address hidden> wrote:

> Hi Jeffrey for the idea, but Gufw is an UI for ufw, then I'm keeping the
> 'keys' of ufw in Gufw.
> ufw Is using from and to for everything, then I'll keep them :)
> from ADDRESS [port PORT] [to ADDRESS [port PORT]
> A hug!
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1826955
>
> Title:
> 'Paste your current local IP' is adding a trailing space
>
> Status in Gufw:
> Fix Committed
>
> Bug description:
> The quick paste button adds the current IP, but when you try to add
> the new rule (Advanced Tab) it gives: "Error: No rules added. Review
> the log" on the bottom of the rules pane.
>
> The Log reads:
> "Error running: /usr/sbin/ufw allow in from 192.168.1.111 to
> 192.168.1.222 > ERROR: Bad destination address." If modifying the rule, it
> disappears.
>
> when clicking the paste button '192.168.1.111 ' is added. Manually
> deleting the trailing space made it work.
>
> Fresh install of Mint 19.1 Tessa with all updates as of 2019/04/29. I
> purged and reinstalled gufw with no success before noticing the
> trailing space.
>
> Current build: Gufw Firewall 18.04.0 © 2008-2015 The Gufw Project
>
> Thank you,
> Jeff
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gui-ufw/+bug/1826955/+subscriptions
>