Shell Command injection in ufw_backend.py
Bug #1410839 reported by
Bernd Dietzel
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Gufw |
Fix Released
|
Critical
|
costales | ||
gui-ufw (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Vivid |
Won't Fix
|
Medium
|
Unassigned |
Bug Description
Firewall Administrators can be tricked by someone to export a profile with Gufw to an special crafted file or path name wich contains shell code.
reason is this line in ufw_backend.py :
def export_
commands.
The rename and delete funktions are also unsave if profile name contains shell code, like semicolons.
Changed in gui-ufw: | |
status: | New → Confirmed |
Changed in gui-ufw: | |
status: | In Progress → Fix Committed |
information type: | Private Security → Public |
Changed in gui-ufw: | |
assignee: | nobody → costales (costales) |
importance: | Undecided → High |
status: | Fix Committed → In Progress |
Changed in gui-ufw: | |
status: | In Progress → Fix Committed |
Changed in gui-ufw (Ubuntu): | |
status: | New → Confirmed |
Changed in gui-ufw: | |
status: | Fix Committed → Fix Released |
Changed in gui-ufw: | |
status: | Fix Released → In Progress |
Changed in gui-ufw: | |
status: | In Progress → Fix Released |
Changed in gui-ufw (Ubuntu Vivid): | |
status: | New → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
tags: | removed: removal-candidate |
information type: | Public → Public Security |
Changed in gui-ufw (Ubuntu): | |
importance: | Undecided → High |
Changed in gui-ufw (Ubuntu Vivid): | |
importance: | Undecided → High |
Changed in gui-ufw (Ubuntu): | |
importance: | High → Medium |
Changed in gui-ufw (Ubuntu Vivid): | |
importance: | High → Medium |
Changed in gui-ufw (Ubuntu Vivid): | |
status: | Fix Committed → Won't Fix |
To post a comment you must log in.
Hi! Thanks a lot for your feedback!
The user only can to create profiles with letters, numbers, dashes and bazaar. launchpad. net/~costales/ gui-ufw/ gufw-15. 04/view/ head:/gufw/ view/preference s.py#L101 bazaar. launchpad. net/%7Ecostales /gui-ufw/ gufw-15. 04/view/ head:/gufw/ view/preference s.py#L101>
underscores.
http://
<http://
A profile with semicolons will be reject.
I was thinking about to filter in the ufw_backend.py in any way?
Best regards!