Search filter is not deleted on emtpy search string if tag_pane is closed

Bug #996236 reported by Stefan Handschuh on 2012-05-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Medium
Izidor Matušov

Bug Description

Version 0.2.9-1 from debian testing (date: 2012-02-13)

In the above stated version of gtg, I could not remove the search filter without using the "Tags sidebar" (tag_pane) , once a search has been perfomed in the quickadd_entry.

A simple patch (that is only supposed to show the idea) against 0.2.9 is attached to this report that affects the on_quickadd_changed method of GTG/gtk/browser/browser.py

However, I assume this behavior is intentional but in case of the tag_pane being not visible, I find this somehow irritating.

Related branches

Stefan Handschuh (handschuh) wrote :
Izidor Matušov (izidor) wrote :

Thanks for the patch. All developers use GTG with the visible tag_page and some strange behavior we don't find ourselves. Your patch looks good and simple. In my opinion, it is too extreme to remove all search tags (somebody might write a complicated query and doesn't want to loose it). Would it be okay with you to delete only the current search filter or just un-apply the search filter?

(I can update the patch)

Changed in gtg:
status: New → Incomplete
importance: Undecided → Medium
milestone: none → 0.3
Stefan Handschuh (handschuh) wrote :

Thank you for your fast response.

Of course, feel free to change the patch in whatever way you like.

Izidor Matušov (izidor) on 2012-05-27
Changed in gtg:
assignee: nobody → Izidor Matušov (izidor)
status: Incomplete → In Progress
Izidor Matušov (izidor) on 2012-08-14
Changed in gtg:
status: In Progress → Fix Committed
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments