hamster applet receives incorrect tags

[Richard Klein]

Trunk version: revno: 1040 revid:<email address hidden>
Affects Hamster Plugin

The error occurs when GTG sets the category from a tag and the current task doesn't have a tag set. GTG crashes with:

Setting XDG vars to use default dataset.
2011-11-29 16:17:54,538 - WARNING - __init__:__init__:77 - Backend backend_mantis could not be loaded: No module named suds.client
Traceback (most recent call last):
  File "/home/ric/gtg/GTG/plugins/hamster/hamster.py", line 244, in browser_cb
    self.sendTask(plugin_api.get_requester().get_task(task_id))
  File "/home/ric/gtg/GTG/plugins/hamster/hamster.py", line 77, in sendTask
    category = gtg_tags[0]
IndexError: list index out of range
Traceback (most recent call last):
  File "/home/ric/gtg/GTG/plugins/hamster/hamster.py", line 244, in browser_cb
    plugin_api.remove_toolbar_item(self.taskbutton)
  File "/home/ric/gtg/GTG/plugins/hamster/hamster.py", line 77, in sendTask
    category = "unsorted"
IndexError: list index out of range

The error occurs as the code on hamster.py Line 77 doesn't check to see that gtg_tags[0] actually exists.

[Richard Klein (kleinric)]

This bug and #897705 have been fix and are in my linked branch

[Lionel Dricot (ploum-deactivatedaccount)]

Hi Richard,

Thanks for your cooperation. We don't mark a bug as fixed as long as it is present in trunk. (see https://live.gnome.org/gtg/bugstriaging )

[Richard Klein (kleinric)]

Hi Lionel & Izidor,

Apologies, I hadn't seen that page. Its the first time I've submitted a bug fix to open source so I'm a little sketchy on the processes.

I'll definitely follow that page in the future.

Thanks,
Richard