notification plugin crash "no attribute 'get_active_tasks_list'" (with fix)

[Paul Ivanov]

Seems like this method has been removed, and the stack trace is:

Traceback (most recent call last):
  File "./gtg", line 66, in <module>
    sys.exit(GTG.gtg.main(options, args))
  File "/home/pi/code/tmp/gtg/trunk/GTG/gtg.py", line 100, in main
    manager = Manager(req, config)
  File "/home/pi/code/tmp/gtg/trunk/GTG/gtk/manager.py", line 75, in __init__
    self.__init_plugin_engine()
  File "/home/pi/code/tmp/gtg/trunk/GTG/gtk/manager.py", line 123, in __init_plugin_engine
    self.pengine.activate_plugins(self.p_apis)
  File "/home/pi/code/tmp/gtg/trunk/GTG/core/plugins/engine.py", line 197, in activate_plugins
    plugin.instance.activate(api)
  File "/home/pi/code/tmp/gtg/trunk/GTG/plugins/notification_area/notification_area.py", line 67, in activate
    self._initialize_automatic_menu()
  File "/home/pi/code/tmp/gtg/trunk/GTG/plugins/notification_area/notification_area.py", line 111, in _initialize_automatic_menu
    task_list = self.requester.get_active_tasks_list(workable = True)
AttributeError: 'Requester' object has no attribute 'get_active_tasks_list'

I implemented a fix for this, but I'm not certain that it was done in the proper way

[Kris Marsh (moogman)]

Reproducable, so set status to confirmed. Steps to reproduce:
* Download gtg (in my case, from bzr).
* Run gtg, and enable the notification plugin.
* Restart gtg, and observe crash.

[Kris Marsh (moogman)]

Related bug 529256 initially requesting "active tasks" be re-added back into the requester.

There's a suggestion there on how the same functionality can be achieved without it, and this is pretty much what the patch is doing.

It's a trivial patch and looks sane to me (also works just fine when I apply it). It's also a fairly high priority bug in that, if someone enables the notification plugin and restarts then GTG no longer works.

GTG Devs: Do you think you could review and commit this?

[Kris Marsh (moogman)]

Paul: I'd suggest removing your 'FIXME' comment (it's place is here, not the code). You probably will also want to remove instead of comment out the buggy line.

[Kris Marsh (moogman)]

I've pushed and related a branch out that includes the same/similar fix to the other affected plugins (including this one).

[Luca Invernizzi (invernizzi)]

Hello everybody, I'm one of the GTG devs.
This crash happens only in the trunk version of GTG, because the plugin api is currently broken. That's because we're finishing a big refactoring of GTG core to make it faster and less exposed to bugs (development branch https://code.edge.launchpad.net/~gtg-user/gtg/liblarch_rebased).
In a few weeks everything should return to normal.
Thanks for the patches!