Error in new_task of requeseter.py when adding tasks with tags

Bug #541943 reported by Zunbeltz Izaola on 2010-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Low
Luca Invernizzi

Bug Description

When adding a task with a tag via dbus there is the following error:

org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/hmi/gtg/GTG/core/dbuswrapper.py", line 107, in new_task
    nt = self.req.new_task(tags=tags)
  File "/hmi/gtg/GTG/core/requester.py", line 90, in new_task
    task.tag_added(t.get_name())
AttributeError: 'dbus.String' object has no attribute 'get_name'

I done a patch for it.

Related branches

Zunbeltz Izaola (zunbeltz) wrote :
Changed in gtg:
status: New → Won't Fix
assignee: nobody → Luca Invernizzi (invernizzi)
importance: Undecided → Low
milestone: none → 0.3
status: Won't Fix → In Progress
Luca Invernizzi (invernizzi) wrote :

Actually, the bug was in dbuswrapper.py (it should have passed the tag object instead of a string).
Since GTG is moving toward always passing strings instead of objects (it's faster and clearer from the developer POV), I've applied your patch and converted all GTG code to the new standard. Nice work!

Changed in gtg:
status: In Progress → Fix Committed
Changed in gtg:
milestone: 0.3 → 0.2.9
Izidor Matušov (izidor) on 2012-02-13
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers