sorting of finished tasks is buggy

[Michael Keppler]

When sorting finished tasks by their finished date, the sorting is buggy (as the order is neither ascending nor descending). This is version 0.2.4. I'm using a German locale, if that matters.

See attached screenshot

[Bryce Harrington (bryce)]

On Sun, Mar 14, 2010 at 07:23:55AM -0000, Michael Keppler wrote:
> Public bug reported:
>
> When sorting finished tasks by their finished date, the sorting is buggy
> (as the order is neither ascending nor descending). This is version
> 0.2.4. I'm using a German locale, if that matters.

Confirmed; I've noticed this as well.

[Karlo Jež (karlo-jez)]

Column COL_CDATE is never displayed, but it is used for sorting. Because it is converted to readable string it is sorted by lexicographic order:

2 days ago
300 days ago
50 days ago
today
tomorrow
yesterday

Since COL_CDATE is not displayed, it does not have to be in readable form. This small patch removes to_readable_string() from the task date returned by func. on_get_value() for the column. It seems to fix the sorting problem.
I guess it would be possible to add a special column_id for sorting, but it seems unnecessary for now.

[Luca Invernizzi (invernizzi)]

I love when patches come in. Thanks!