[gtg-refactor] DBus api is broken due to requester changes

[Bryce Harrington]

From Lionel's status email today:

- DBus is broken, due to the huge change to the requester.

This affects the gtg_new_task tool and other consumers of the dbus service.

[Philippe Le Toquin (ppmt)]

not sure if it the same but I use the bzr 0.2.2 and I have the same problem. the dbus commands don't seem to work anymore.

[Luca Invernizzi (invernizzi)]

That's not the same bug, please open a new bug. In my copy of gtg 0.2.4 it works fine, so please check again. Mahalo.

[Zunbeltz Izaola (zunbeltz)]

I can confim that get_tasks_filtered is not working.

org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/home/zunbeltz/gtg-bugs/GTG/viewmanager/dbuswrapper.py", line 94, in get_tasks_filtered
    tags, status, started_only, is_root)
  File "/home/zunbeltz/gtg-bugs/GTG/viewmanager/dbuswrapper.py", line 84, in get_task_ids_filtered
    ids = self.req.get_tasks_list(
AttributeError: 'Requester' object has no attribute 'get_tasks_list'

I tied to look at it but I do not understand how the filtering stuff works.

[Bryce Harrington (bryce)]

I've updated the dbus commands on the 0.3 branch to work with the new filters system. I had to change the API a bit since some of the internal functionality has changed around.

get_tasks_filtered() and get_task_ids_filtered() are the major changes. Both routines are still present but their parameter signatures are changed - they now use filters directly. Unfortunately because of this they no longer support searching by tags, but on the plus side they now will work with any filter, so as new filters are added in the future, this will all "just work".

get_task_ids() is dropped. I decided if someone needs that, they can just use get_task_ids_filtered().

I decided to keep get_tasks() as a convenience function. Basically it just calls self.get_tasks_filtered(['all'])

Also, I've implemented a command line tool gtcli in trunk which has been quite handy in testing out the dbus API. I plan to continue maintaining this and adding to it, and patches for it are of course quite welcome!